Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move database settings from models to setting #7806

Merged
merged 9 commits into from
Aug 24, 2019
Merged

Move database settings from models to setting #7806

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8946315
move database settings from models to setting
lunny Aug 9, 2019
0765f90
update docs
lunny Aug 9, 2019
9e4ebd5
fix checkout pr
lunny Aug 9, 2019
d25ffdd
fix tests
lunny Aug 9, 2019
292a68a
fix lint
lunny Aug 9, 2019
bed6120
remove unsupported tidb options
lunny Aug 9, 2019
18fd92c
correct wrong variable name
lunny Aug 10, 2019
1d70d10
remove tidb totally
lunny Aug 10, 2019
4c4773b
Merge branch 'master' into lunny/db_config
techknowlogick Aug 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
correct wrong variable name
  • Loading branch information
@lunny
lunny committed Aug 15, 2019
commit 18fd92ce112958fb57b49aa026fa6f8940c1f54c
4 changes: 2 additions & 2 deletions models/models_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ func TestDumpDatabase(t *testing.T) {
dir, err := ioutil.TempDir(os.TempDir(), "dump")
assert.NoError(t, err)

for _, dbType := range setting.SupportedDatabases {
dbType = setting.GetDBTypeByName(dbType)
for _, dbName := range setting.SupportedDatabases {
dbType := setting.GetDBTypeByName(dbName)
assert.NoError(t, DumpDatabase(filepath.Join(dir, dbType+".sql"), dbType))
}
}