Add Bucket Storage Support for files #7795

masudur-rahman · 2019-08-08T05:37:58Z

Add bucket storage support for the following items:
- avatars
- repo-avatars
- attachments
- lfs

lafriks · 2019-08-08T07:44:14Z

modules/setting/setting.go

@@ -613,7 +621,7 @@ func NewContext() {
 	OfflineMode = sec.Key("OFFLINE_MODE").MustBool()
 	DisableRouterLog = sec.Key("DISABLE_ROUTER_LOG").MustBool()
 	StaticRootPath = sec.Key("STATIC_ROOT_PATH").MustString(AppWorkPath)
-	AppDataPath = sec.Key("APP_DATA_PATH").MustString(path.Join(AppWorkPath, "data"))
+	AppDataPath = sec.Key("APP_DATA_PATH").MustString("data")


This should not be changed

@lafriks ,I need the followings:

AvatarUploadPath = "data/avatars/" LFS.ContentPath = "data/lfs/" AttachmentPath = "data/attachments/" RepositoryAvatarUploadPath = "data/repo-avatars/"

Should I use:
LFS.ContentPath = sec.Key("LFS_CONTENT_PATH").MustString(filepath.Join("data", "lfs/"))
instead of:
LFS.ContentPath = sec.Key("LFS_CONTENT_PATH").MustString(filepath.Join(AppDataPath, "lfs"))

Problem is that this is just defaults. User could have specified completely different paths in their app.ini for ex:

AvatarUploadPath = "/srv/avatars/upload/" LFS.ContentPath = "/srv/lfs/" AttachmentPath = "/srv/attachments/" RepositoryAvatarUploadPath = "/srv/avatars/repo-upload/"

And in such configuration your code will not work for local storage anymore

It will work for either local or any other cloud storage.
By default I set it to local storage. https://github.com/go-gitea/gitea/blob/16ac0bb98f889f15628e1779889fd0b689927f2a/modules/setting/file_storage.go#L10-L23
If user wants to use any other cloud storage or other local storage, they just have to specify it in their app.ini

Users are free to provide their own upload path like you suggested and it will work fine.

I meant it should work for local storage same as it was before without changing app.ini

Yes, it will work as it was before. Just the files will be stored in the directory specified in FileStorage.BucketURL.

So, what do you suggest about #7795 (comment) ?

So I've checked out this PR and ran it with my usual test settings:

[server] SSH_DOMAIN = .... DOMAIN = .... HTTP_PORT = .... PROTOCOL = http ROOT_URL = .... OFFLINE_MODE = false APP_DATA_PATH = /mnt/external/my_test_data

Then I've changed my avatar. I expected the avatar to be created at:

/mnt/external/my_test_data/avatars/a9050bf53d1005dfe5398ce9fa5b07aa

Instead, with this PR, the avatar was incorrectly created at:

/home/giteatest/avatars/a9050bf53d1005dfe5398ce9fa5b07aa

As you can see, with this PR Gitea completely ignored the value of my APP_DATA_PATH. This is the breaking change we've been talking about. The code must behave like it did before this PR if the user doesn't change their app.ini. Users that upgrade to this must not notice any difference, unless they actively decide to use the new bucket storage capability.

I hope that this example helps.

Hey @guillep2k, thanks for taking the time for testing.

If AVATAR_UPLOAD_PATH is set either relative or absolute, it ignores APP_DATA_PATH as it was ignored previously.

gitea/modules/setting/setting.go

Lines 850 to 854 in 111d31d

AvatarUploadPath = sec.Key("AVATAR_UPLOAD_PATH").MustString(path.Join(AppDataPath, "avatars"))

forcePathSeparator(AvatarUploadPath)

if !filepath.IsAbs(AvatarUploadPath) {

AvatarUploadPath = path.Join(AppWorkPath, AvatarUploadPath)

}

But if AVATAR_UPLOAD_PATH is not specified, then it uses APP_DATA_PATH+"avatars" to read or store the avatars.

Either way if the AvatarUploadPath is relative then the whole path to store the avatars is AppWorkPath+AvatarUploadPath.
If the path is absolute the avatars is stored to AvatarUploadPath.
It works like it did previously.

I've attached the scenarios here :

gitea/modules/storage/storage.go

Lines 124 to 154 in e29ba59

/*

- Path represents AttachmentPath, AvatarUploadPath, RepositoryAvatarUploadPath or LFS.ContentPath

- corresponding default PathValues are : "attachments", "avatars", "repo-avatars" & "lfs"

- appDataUserPath defaults to "data"

There may be two scenarios:

s1:

Path is set in app.ini (rel or abs)

s2:

Path is unset in app.ini

Path <= appDataUserPath + Path

If appDataUserPath is set to abs in app.ini (via APP_DATA_PATH)

Path is abs

Otherwise

Path is rel

If Path is abs, the files will be read or stored to that abs Path even if the BUCKET_URL is set.

Otherwise the following occurs,

if BUCKET_URL NOT SET {

Path = file://{AppWorkPath}/{Path}

} else {

Path is used as Bucket prefix

}

*/

May be there was some errors in my previous commit but I refactored the code and I hope it works like it did before this pr.

Please, pull again and check if it's now okay. Thanks again.

lafriks · 2019-08-08T07:49:39Z

modules/setting/setting.go

-		LFS.ContentPath = filepath.Join(AppWorkPath, LFS.ContentPath)
-	}
+	forcePathSeparator(LFS.ContentPath)
+	LFS.ContentPath = suffixPathSeparator(LFS.ContentPath)


This breaks current behavior and is not really related to this PR

masudur-rahman · 2019-08-09T12:40:05Z

Hey @lafriks , previously I misunderstood you.
I have changed the code to be backward compatible. Please, let me know if anything needs to be changed.

docs/content/doc/advanced/config-cheat-sheet.en-us.md

lafriks · 2019-08-20T07:44:43Z

models/migrations/migrations.go

-			isSucceed = false
-			return err
-		}
+		if filepath.IsAbs(setting.AttachmentPath) {


Why checking only for absolute attachment path?

I have updated it. I've attached a summary how whole BucketURL and AttachmentPath or others work.
https://github.com/go-gitea/gitea/blob/4c390c9699ee6400a9467c4c8234af9efba5acaf/modules/setting/setting.go#L1053-L1083

Please take a look if it seems okay. Thanks

lafriks · 2019-08-20T07:45:56Z

models/migrations/v61.go

+	var bucket *blob.Bucket
+	var err error
+	ctx := context.Background()
+	if filepath.IsAbs(setting.AttachmentPath) {


IMHO it should be checking for some other setting not if path is absolute

docs/content/doc/advanced/config-cheat-sheet.en-us.md.orig

models/admin.go

lunny · 2019-08-20T12:55:35Z

I think we should have an abstract layout under modules/ i.e. modules/fs to let people chose file system or block storage.

codecov-io · 2019-08-20T14:23:50Z

Codecov Report

Merging #7795 into master will decrease coverage by 0.01%.
The diff coverage is 43.97%.

@@            Coverage Diff             @@
##           master    #7795      +/-   ##
==========================================
- Coverage   41.74%   41.72%   -0.02%     
==========================================
  Files         526      528       +2     
  Lines       68398    68634     +236     
==========================================
+ Hits        28553    28638      +85     
- Misses      36201    36340     +139     
- Partials     3644     3656      +12

Impacted Files	Coverage Δ
modules/avatar/avatar.go	`48% <ø> (ø)`	⬆️
routers/repo/setting.go	`13.2% <0%> (-0.1%)`	⬇️
models/migrations/v61.go	`0% <0%> (ø)`	⬆️
modules/migrations/gitea.go	`11.72% <0%> (-0.03%)`	⬇️
routers/user/setting/profile.go	`38.7% <0%> (-1.56%)`	⬇️
routers/routes/routes.go	`81.68% <25%> (-0.7%)`	⬇️
models/user.go	`50.13% <28.57%> (-0.05%)`	⬇️
modules/public/avatars.go	`34.54% <34.54%> (ø)`
modules/storage/storage.go	`39.13% <39.13%> (ø)`
models/repo.go	`49.24% <40.32%> (+0.29%)`	⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d151503...caa31bc. Read the comment docs.

guillep2k · 2019-08-20T17:26:08Z

custom/conf/app.ini.sample

+
+[storage]
+; URL of Bucket where files, such as, attachments, avatars, etc. are stored
+; If unset, file://<current_directory> is used to maintain backward compatibility


"backward compatibility" makes it sound like buckets are the "modern" way to go. Could this be changed to something like "if unset, {APP_DATA_PATH}/attachments is used" (not checked) or something around those lines?

Actually if unset, it now uses AppWorkPath. When using this path for attachments or avatars, AttachmentPath or AvatarUploadPath is appended to this BucketURL.
If AttachmentPath is unset, we set this as data/attachments, to maintain similarity between all the available buckets.

gitea/modules/setting/setting.go

Line 803 in 83ccf4c

AttachmentPath = sec.Key("PATH").MustString(path.Join("data", "attachments"))

So, if I understand well, the user can't use APP_DATA_PATH anymore? I think it's too big of a breaking change. If the user upgrades because they were interested in X other functionality the new version provides, he or she might not be aware of this change and get in a lot of trouble. Can't they both co-exist? e.g. if there are both APP_DATA_PATH and BUCKET_URL, then the former should be ignored, but if there's only APP_DATA_PATH, the old behaviour should be honored.

APP_DATA_PATH related issue is now fixed.
https://github.com/go-gitea/gitea/blob/4c390c9699ee6400a9467c4c8234af9efba5acaf/modules/setting/setting.go#L1053-L1083

Now, APP_DATA_PATHand BUCKET_URL both co-exist. Please let me know if I did it right.

guillep2k · 2019-08-20T17:31:19Z

models/admin.go

+	ctx := context.Background()
+	bucket, err := setting.OpenBucket(ctx, bucketPath)
+	if err != nil {
+		return fmt.Errorf("could not open bucket: %v", err)


Is there a way to make an error here gracefully fail, so the user can attempt to retry the operation? Third-party requests are likely to fail at some point.

The error related to OpenBucket is handled by the bucket providers using exponential backoff algo. I think it's okay not to handle it here.

guillep2k · 2019-08-20T17:32:36Z

models/attachment.go

+	ctx := context.Background()
+	bucket, err := setting.OpenBucket(ctx, setting.AttachmentPath)
+	if err != nil {
+		return nil, fmt.Errorf("could not open bucket: %v", err)


Same thing as above about gracefully return connection errors.

masudur-rahman · 2019-08-21T12:13:59Z

I think we should have an abstract layout under modules/ i.e. modules/fs to let people chose file system or block storage.

Hey @lunny, I am working on that now. I will commit those changes in a separate commit.
Please take a look if the changes are okay or any thing needs to be changed. Thanks

masudur-rahman · 2019-08-22T15:14:11Z

@lunny , I have refactored this pr. I moved the FileStorage thing to modules/storage.
https://github.com/go-gitea/gitea/blob/e29ba594b069ae3011601ba210b40cbe9a057ff1/modules/storage/storage.go

I hope these changes serve the abstract layout you asked for.
Please let me know if everything's okay. Thanks.

tamalsaha · 2019-08-23T00:56:08Z

@lunny / @lafriks / @guillep2k and folks, if you can take another look at it that will be great.

guillep2k · 2019-08-23T01:24:25Z

Now the APP_DATA_PATH setting seems to be working (at least for avatars), but for some reason uploading a picture leaves an .attrs file behind that I don't think I've seen before:

-rw-------+ 1 giteatest giteatest 269836 Aug 22 22:17 my_test_data/avatars/9-eae2c62356750433ffc3c52ffb9ceee9
-rw-rw----+ 1 giteatest giteatest    196 Aug 22 22:17 my_test_data/avatars/9-eae2c62356750433ffc3c52ffb9ceee9.attrs

Contents:

{"user.cache_control":"","user.content_disposition":"","user.content_encoding":"","user.content_language":"","user.content_type":"image/png","user.metadata":null,"md5":"a+USfqDVjIMq4Sy3HXOWdA=="}

Why is it there? Is that a side-effect of your changes?

tamalsaha · 2019-08-23T01:31:32Z

@guillep2k , this is a result of using the go-cloud/blob/fileblob driver. This library stores file attributes in this .attrs file .

tamalsaha · 2019-08-23T22:51:52Z

Please take a look. The git conflicts are fixed.

guillep2k · 2019-08-24T15:38:59Z

Weird fail in the build. Somebody will restart it soon.

lunny · 2019-08-25T17:33:41Z

I will review this ASAP.

masudur-rahman · 2019-08-29T12:26:19Z

@lunny, I keep getting build fail after resolving the conflicts. I ran go mod tidy && go mod vendor every time after resolving the conflicts.
But there is some dissimilarity in vendor/modules.txt between my version and continuous-integration/drone/pr version which I don't know why.

My go version is go1.12.9.

Can you please give me some suggestions what should I do to resolve this problem ?

lunny · 2019-09-03T01:50:20Z

@masudur-rahman CI failed because of other reason and just fixed. Please resolve the conflicts.

masudur-rahman · 2019-09-03T05:28:50Z

@lunny, I resolved the conflicts and kept the changes in a single commit. Still getting build fail due to modules.txt.

masudur-rahman · 2019-10-07T21:43:28Z

At last the continuous-integration/drone/pr is passing. May be it will be failing after merging some other pr.
@lunny , @lafriks & @guillep2k , can you guys please take a look while continuous-integration/drone/pr is passing ?

Thanks...

lunny · 2019-10-08T02:06:12Z

models/attachment.go

 	if err != nil {
 		return nil, fmt.Errorf("Create: %v", err)
 	}
-	defer fw.Close()



just keep defer fw.Close() is better.

defer fw.Close() can't be used here.
fw must be closed before fi, err := fs.Attributes() (Line 105). It can't open the file for attributes unless the fw.Close() is called.

That's why I had to do like this.

I don't know about fw, but in many libraries Close() can be called twice without any side effects. So you can defer fw.Close() and call fw.Close() later when you need to.

Sorry for the late.
Your suggestion will work fine here and will do that.

guillep2k

Decidedly not an easy PR to review. 😅

guillep2k · 2019-10-08T23:53:08Z

models/attachment.go

 	if err != nil {
 		return nil, fmt.Errorf("Create: %v", err)
 	}
-	defer fw.Close()



I don't know about fw, but in many libraries Close() can be called twice without any side effects. So you can defer fw.Close() and call fw.Close() later when you need to.

guillep2k · 2019-10-08T23:56:19Z

models/migrations/v61.go

+		Ctx:  context.Background(),
+		Path: setting.AttachmentPath,
+	}
+
 	for _, attach := range attachments {


I think that for the duration of this migration you should override the configuration value and make sure local file:// is used. But make sure to restore the configured value before exiting the function, as Gitea will start afterwards.

Yes, that's very necessary.

guillep2k · 2019-10-09T00:05:52Z

models/repo.go

+	fs := storage.FileStorage{
+		Ctx:      context.Background(),
+		Path:     setting.RepositoryAvatarUploadPath,
+		FileName: repo.Avatar,


What happens if two users choose the same file name for their repo avatars?

Here, <repo.ID>-<md5.Sum(data)> is used as repo.Avatar. So even if two user uses same file, repo.ID will differ them.
https://github.com/go-gitea/gitea/blob/98c0c8ea2e0d4896cc3cc00423f0d2952fcbad21/models/repo.go#L2718

guillep2k · 2019-10-09T00:08:11Z

models/user.go

+	fs := storage.FileStorage{
+		Ctx:      context.Background(),
+		Path:     setting.AvatarUploadPath,
+		FileName: u.Avatar,


Same question as for repo avatar file name.

Same answer as for repo.avatar.
But previously, if two users uploaded the same file, it would replace the previous one (also in previous system).

gitea/models/user.go

Line 523 in d4cd4ed

u.Avatar = fmt.Sprintf("%x", md5.Sum(data))

I used same format as repo.Avatar to avoid this collision.
https://github.com/go-gitea/gitea/blob/98c0c8ea2e0d4896cc3cc00423f0d2952fcbad21/models/user.go#L533

guillep2k · 2019-10-09T00:10:13Z

modules/migrations/gitea.go

-			localPath := attach.LocalPath()
-			if err = os.MkdirAll(path.Dir(localPath), os.ModePerm); err != nil {
-				return fmt.Errorf("MkdirAll: %v", err)
+			fs := storage.FileStorage{


This is trickier. Depeding on the current version value you should or should not ignore the app.ini setting and use local file storage in this function.

guillep2k · 2019-10-09T00:12:17Z

modules/public/avatars.go

+// AvatarOptions represents the available options to configure the AvatarHandler.
+type AvatarOptions struct {
+	Prefix      string
+	SkipLogging bool


Is this necessary? The new logger system allows to set logging levels for different features individually.

I followed the existing Options structure to handle this part.

gitea/modules/public/public.go

Lines 24 to 33 in d4cd4ed

type Options struct {

Directory string

IndexFile string

SkipLogging bool

// if set to true, will enable caching. Expires header will also be set to

// expire after the defined time.

ExpiresAfter time.Duration

FileSystem http.FileSystem

Prefix string

}

I didn't realize that.

guillep2k · 2019-10-09T00:19:26Z

modules/public/avatars.go

+		}
+	}
+
+	fr, err := fs.NewReader()


I think users (admins) should decide which resources are handled locally or remotely. Avatars are too time-sensitive to keep in a remote server, especially if they need to pass through Gitea to be retrieved. Attachments are usually the images of issues and PRs, so they too are pretty much time-sensitive. The Etag of course helps a lot. Nonetheless, I'd have three separate settings: one for avatars, one for attachments and one for LFS. Even let the admin set different services for each one.

guillep2k · 2019-10-09T00:22:22Z

modules/setting/setting.go

@@ -774,11 +782,15 @@ func NewContext() {

 	InternalToken = loadInternalToken(sec)

+	sec = Cfg.Section("storage")


As said above, I'd have three sections: [storage.avatars], [storage.attachments], [storage.lfs]. Or some flexible system like that.

guillep2k · 2019-10-09T00:25:31Z

modules/storage/storage.go

+}
+
+// NewReader provides file reader from bucket and error if occurs
+func (fs *FileStorage) NewReader() (*blob.Reader, error) {


If you pass an enum here, it's easy to decide between different file storages.

If we want to separate storage system for avatars, lfs, attachments ( [storage.avatars], [storage.attachments], [storage.lfs] ), we can use an extra field BucketURL here which will be useful to decide between file storages.
https://github.com/go-gitea/gitea/blob/98c0c8ea2e0d4896cc3cc00423f0d2952fcbad21/modules/storage/storage.go#L22-L26

guillep2k · 2019-10-09T00:40:17Z

One important aspect that I didn't see covered: how does one user migrate from one storage system to another? For example: I decide I need aws for my files, but my repository is already up and running. If I change app.ini, all my files will be suddenly gone! I'd need some tool to transfer all my files to the new storage and then start Gitea.

masudur-rahman · 2019-10-16T17:59:35Z

One important aspect that I didn't see covered: how does one user migrate from one storage system to another? For example: I decide I need aws for my files, but my repository is already up and running. If I change app.ini, all my files will be suddenly gone! I'd need some tool to transfer all my files to the new storage and then start Gitea.

@guillep2k , we can use a cmd like gitea migrate-storage to do the migration. Here we can assume that previous storage is file://<AppWorkPath> unless otherwise specified for the avatars, lfs and attachments .
But if any user using bucket storage system, wants to switch between different cloud storages, it would be a bit difficult.

guillep2k · 2019-10-16T23:14:12Z

A migration tool will be needed indeed. Between different cloud storages I don't know, but at least between any cloud storage and file://. And it should be reversible (e.g. file names should not be problem, even if e.g. avatars get a different name when migrated).

Signed-off-by: Masudur Rahman <masud@appscode.com>

lunny · 2019-10-18T08:32:47Z

Should we provide a new command to copy local directory data to a storage?

guillep2k · 2019-10-18T12:13:29Z

Should we provide a new command to copy local directory data to a storage?

@lunny You mean something like this?:

A migration tool will be needed indeed. Between different cloud storages I don't know, but at least between any cloud storage and file://. And it should be reversible (e.g. file names should not be problem, even if e.g. avatars get a different name when migrated).

lunny · 2019-10-28T02:58:28Z

I would like we have an abstract filesystem layer before this PR. Something like https://godoc.org/github.com/blang/vfs or other better libraries. So we could support both local file system, blob storages and other storage facilities if there are implements for them.

lunny · 2019-10-28T12:53:45Z

Or https://github.com/spf13/afero

patcito · 2019-12-06T00:06:05Z

Any news about this? @masudur-rahman @tamalsaha

stale · 2020-02-04T10:33:34Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

masudur-rahman force-pushed the bucket branch 5 times, most recently from 9b8c837 to e62302b Compare August 8, 2019 07:44

lafriks requested changes Aug 8, 2019

View reviewed changes

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 8, 2019

lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Aug 8, 2019

masudur-rahman force-pushed the bucket branch 3 times, most recently from af91ca1 to 8e770d0 Compare August 20, 2019 06:29

lafriks reviewed Aug 20, 2019

View reviewed changes

docs/content/doc/advanced/config-cheat-sheet.en-us.md Outdated Show resolved Hide resolved

lafriks reviewed Aug 20, 2019

View reviewed changes

lunny requested changes Aug 20, 2019

View reviewed changes

docs/content/doc/advanced/config-cheat-sheet.en-us.md.orig Outdated Show resolved Hide resolved

models/admin.go Outdated Show resolved Hide resolved

masudur-rahman force-pushed the bucket branch from 988ad55 to 83ccf4c Compare August 20, 2019 13:59

guillep2k reviewed Aug 20, 2019

View reviewed changes

masudur-rahman force-pushed the bucket branch from 4c390c9 to 49c82a0 Compare August 21, 2019 11:57

masudur-rahman force-pushed the bucket branch 2 times, most recently from 9ea8ebe to e29ba59 Compare August 22, 2019 11:51

masudur-rahman force-pushed the bucket branch from 1cde6e4 to 838e1b0 Compare August 23, 2019 08:56

masudur-rahman changed the title ~~Replace local File storage with Bucket storage for avatars, repo-avatars, attachments & lfs~~ Add Bucket Storage Support for files Aug 25, 2019

masudur-rahman force-pushed the bucket branch from b0eb4d0 to 7d714c4 Compare September 3, 2019 04:47

masudur-rahman force-pushed the bucket branch from 8f89c76 to 13adc4c Compare September 9, 2019 08:40

masudur-rahman force-pushed the bucket branch from 13adc4c to 0e9676f Compare September 16, 2019 12:29

masudur-rahman force-pushed the bucket branch from 0e9676f to 98c0c8e Compare October 7, 2019 21:16

lunny reviewed Oct 8, 2019

View reviewed changes

guillep2k reviewed Oct 9, 2019

View reviewed changes

masudur-rahman added 2 commits October 18, 2019 02:36

Add Bucket Storage Support for files

a9f3b32

Signed-off-by: Masudur Rahman <masud@appscode.com>

Fix fw.Clowe()

caa31bc

masudur-rahman force-pushed the bucket branch from 98c0c8e to caa31bc Compare October 17, 2019 21:22

patcito mentioned this pull request Dec 22, 2019

make it possible to use cloud storage for git lfs and gitea in general patcito/gitea#1

Closed

5 tasks

cuonglm mentioned this pull request Dec 31, 2019

NOT MERGED: Add bucket storage support #9567

Merged

stale bot added the issue/stale label Feb 4, 2020

lafriks closed this Feb 4, 2020

go-gitea locked and limited conversation to collaborators Nov 24, 2020

	AvatarUploadPath = sec.Key("AVATAR_UPLOAD_PATH").MustString(path.Join(AppDataPath, "avatars"))
	forcePathSeparator(AvatarUploadPath)
	if !filepath.IsAbs(AvatarUploadPath) {
	AvatarUploadPath = path.Join(AppWorkPath, AvatarUploadPath)
	}

	/*
	- Path represents AttachmentPath, AvatarUploadPath, RepositoryAvatarUploadPath or LFS.ContentPath
	- corresponding default PathValues are : "attachments", "avatars", "repo-avatars" & "lfs"

	- appDataUserPath defaults to "data"

	There may be two scenarios:

	s1:
	Path is set in app.ini (rel or abs)

	s2:
	Path is unset in app.ini
	Path <= appDataUserPath + Path

	If appDataUserPath is set to abs in app.ini (via APP_DATA_PATH)
	Path is abs
	Otherwise
	Path is rel


	If Path is abs, the files will be read or stored to that abs Path even if the BUCKET_URL is set.
	Otherwise the following occurs,

	if BUCKET_URL NOT SET {
	Path = file://{AppWorkPath}/{Path}
	} else {
	Path is used as Bucket prefix
	}

	*/

	type Options struct {
	Directory string
	IndexFile string
	SkipLogging bool
	// if set to true, will enable caching. Expires header will also be set to
	// expire after the defined time.
	ExpiresAfter time.Duration
	FileSystem http.FileSystem
	Prefix string
	}

		@@ -774,11 +782,15 @@ func NewContext() {

		InternalToken = loadInternalToken(sec)

		sec = Cfg.Section("storage")

Uh oh!

Add Bucket Storage Support for files #7795

Add Bucket Storage Support for files #7795

Uh oh!

Conversation

masudur-rahman commented Aug 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

masudur-rahman Aug 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

masudur-rahman Aug 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

masudur-rahman commented Aug 9, 2019

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lunny commented Aug 20, 2019

Uh oh!

codecov-io commented Aug 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

masudur-rahman commented Aug 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

masudur-rahman commented Aug 22, 2019

Uh oh!

tamalsaha commented Aug 23, 2019

Uh oh!

guillep2k commented Aug 23, 2019

Uh oh!

tamalsaha commented Aug 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tamalsaha commented Aug 23, 2019

Uh oh!

guillep2k commented Aug 24, 2019

Uh oh!

lunny commented Aug 25, 2019

Uh oh!

masudur-rahman commented Aug 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

masudur-rahman commented Aug 8, 2019 •

edited

Loading

masudur-rahman Aug 8, 2019 •

edited

Loading

masudur-rahman Aug 22, 2019 •

edited

Loading

codecov-io commented Aug 20, 2019 •

edited

Loading

masudur-rahman commented Aug 21, 2019 •

edited

Loading

tamalsaha commented Aug 23, 2019 •

edited

Loading

masudur-rahman commented Aug 29, 2019 •

edited

Loading