v1.9 Backport for #7478 - Fix for bad error if Deleting a file has problems #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gitea#7478) * Fixes go-gitea#7474 - Handles all redirects for Web UI File CRUD * Fixes lint errors * Typo fix * Adds unit tests for a few helper functions * Fixes per review * Fix for new branch creation and to unit test * Fixes the template used for errors on delete
richmahn
changed the title
lafriks
approved these changes
Jul 17, 2019
GiteaBot
added
the
lgtm/need 1
mrsdizzie
approved these changes
Jul 17, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport for PR #7478, cherry-picked, fixes #7474 & #7492.
Found that you could never get an error message when deleting a file as then it would try to use the edit file page template and that would throw errors. Also it had the wrong comparison sign for when looking to see if you can commit to the existing branch when you really want to make a new branch. Also makes sure users are redirected to the "compare" page for PR creation page when they chose to start a new branch when saving/deleting a file.