Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug conflict between SyncReleasesWithTags and InsertReleases #7337

Merged
merged 5 commits into from
Jul 1, 2019
Merged

Fix bug conflict between SyncReleasesWithTags and InsertReleases #7337

merged 5 commits into from
Jul 1, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 1, 2019

This bug is caused by #7050. In that PR, we always insert releases batchly, but that releases maybe added when SyncReleasesWithTags which invoked after git repository created. It will make migrating releases failed.

This PR will move SyncReleasesWithTags from clone function to CreateReleases if releases migrating is enabled.

@lunny lunny added the type/bug label Jul 1, 2019
@lunny lunny added this to the 1.9.0 milestone Jul 1, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 1, 2019
@zeripath
Copy link
Contributor

zeripath commented Jul 1, 2019

You need to fix the tests however

@codecov-io
Copy link

codecov-io commented Jul 1, 2019 •
edited
Loading

Codecov Report

Merging #7337 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7337      +/-   ##
==========================================
+ Coverage   41.25%   41.26%   +<.01%     
==========================================
  Files         466      466              
  Lines       63254    63258       +4     
==========================================
+ Hits        26097    26101       +4     
- Misses      33746    33747       +1     
+ Partials     3411     3410       -1
Impacted Files Coverage Δ
modules/migrations/migrate.go 20.77% <100%> (ø) ⬆️
models/repo.go 48.71% <100%> (ø) ⬆️
modules/migrations/gitea.go 7.78% <66.66%> (+0.2%) ⬆️
modules/log/log.go 69.36% <0%> (-2.71%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdd199...f426264. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 1, 2019
@zeripath zeripath merged commit e728b55 into go-gitea:master Jul 1, 2019
@lunny lunny deleted the lunny/fix_migrate branch July 2, 2019 01:30
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Fix bug conflict between SyncReleasesWithTags and InsertReleases (go-…
b30845d 
…gitea#7337)

* fix bug conflict between SyncReleasesWithTags and InsertReleases

* fix tests

* fix fmt
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @zeripath @codecov-io @techknowlogick @GiteaBot