Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] mod: update locked down go-mssqldb to old version #7294

Closed
wants to merge 15 commits into from

Conversation

sapk
Copy link
Member

@sapk sapk commented Jun 25, 2019

mssql driver was locked down to an old version.
I suspect because of xorm not using go.mod previously and that we haven't mssql test integration also.
But now, both are fixed.

Compare link: denisenkom/go-mssqldb@e32ca50...b04fd42

@sapk sapk changed the title mod: remove locked down go-mssqldb to old version mod: update locked down go-mssqldb to old version Jun 25, 2019
@sapk sapk changed the title mod: update locked down go-mssqldb to old version [WIP] mod: update locked down go-mssqldb to old version Jun 25, 2019
@sapk
Copy link
Member Author

sapk commented Jun 25, 2019

I will investigate why the database is not cleared for tests.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2019
@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #7294 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7294      +/-   ##
==========================================
+ Coverage   41.15%   41.16%   +<.01%     
==========================================
  Files         464      464              
  Lines       62763    62763              
==========================================
+ Hits        25833    25834       +1     
+ Misses      33537    33535       -2     
- Partials     3393     3394       +1
Impacted Files Coverage Δ
models/gpg_key.go 55.83% <0%> (-0.84%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5908bb1...e2d3d2d. Read the comment docs.

@lunny
Copy link
Member

lunny commented Jun 26, 2019

@sapk Thanks. I have tried to fix this at PR #7271 , but it needs more time to investigate that so I keep it unchanged.

@sapk
Copy link
Member Author

sapk commented Jun 26, 2019

Yes doing so I remember also playing with it previously. I will try to narrow done the exact commit that fail.

@sapk
Copy link
Member Author

sapk commented Jun 26, 2019

Seems to be a commit between denisenkom/go-mssqldb@94099f0...9340cdc

@sapk
Copy link
Member Author

sapk commented Jun 26, 2019

We will need to wait for the last test to confirm but it should be denisenkom/go-mssqldb@9340cdc that is blocking.

@zeripath
Copy link
Contributor

@sapk is it only the migration test that's failing? It might just be easier to fix the migration test surely?

@sapk
Copy link
Member Author

sapk commented Jun 29, 2019

@zeripath It is the first step (remove of old database) that fail silently so all subsequent call fail. I don't know if it impact later other things as I don't know why the delete hasn't work (and the command return successful).

@sapk sapk closed this Jul 26, 2019
@sapk sapk deleted the remove-gomod-replace branch July 26, 2019 01:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants