Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add state param to milestone listing API #7131

Merged
merged 7 commits into from
Jun 6, 2019
Merged

Add state param to milestone listing API #7131

merged 7 commits into from
Jun 6, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jun 5, 2019

Fixes #6384

This PR adds a state query param to the milestone listing API such as https://developer.github.com/v3/issues/milestones/#list-milestones-for-a-repository

@adelowo adelowo force-pushed the add_param_to_issue_list_api branch from 3a77c1a to 25c3c9b Compare June 5, 2019 15:41
@adelowo adelowo mentioned this pull request Jun 5, 2019
Closed
@esfraner
Copy link

esfraner commented Jun 5, 2019

It is posible to use all as parameter to get milestone list? state=all

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 5, 2019
@mmarif4u
Copy link

mmarif4u commented Jun 5, 2019

Thanks @adelowo for the PR. 👍

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 5, 2019
@techknowlogick techknowlogick added the modifies/api This PR adds API routes or modifies them label Jun 5, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 5, 2019
@adelowo
Copy link
Member Author

adelowo commented Jun 5, 2019 •
edited
Loading

Will update the PR to include all

@esfraner done :)

@codecov-io
Copy link

codecov-io commented Jun 5, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@59e6a7b). Click here to learn what that means.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7131   +/-   ##
=========================================
  Coverage          ?   41.59%           
=========================================
  Files             ?      446           
  Lines             ?    60863           
  Branches          ?        0           
=========================================
  Hits              ?    25314           
  Misses            ?    32266           
  Partials          ?     3283
Impacted Files Coverage Δ
routers/api/v1/repo/milestone.go 0% <0%> (ø)
models/issue_milestone.go 59.17% <100%> (ø)
routers/repo/issue.go 35.87% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e6a7b...275d9da. Read the comment docs.

@adelowo adelowo force-pushed the add_param_to_issue_list_api branch from 28b1cc9 to 171e66a Compare June 5, 2019 16:49
@adelowo adelowo force-pushed the add_param_to_issue_list_api branch from 512ee90 to ebe21b1 Compare June 5, 2019 18:25
@esfraner
Copy link

esfraner commented Jun 5, 2019

Will update the PR to include all

@esfraner done :)

Thanks for the effort! 😄

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 6, 2019
@lunny lunny merged commit de6539f into go-gitea:master Jun 6, 2019
@adelowo adelowo deleted the add_param_to_issue_list_api branch June 6, 2019 03:47
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@adelowo @jeffliu27
Add state param to milestone listing API (go-gitea#7131)
e197223 
* Support state params

* update tests

* fix tests

* add state=all support

* update tests

* update swagger

* update swagger
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tonivj5 tonivj5 tonivj5 left review comments

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

[API] Add params to milestone API with order
9 participants
@adelowo @esfraner @mmarif4u @codecov-io @lunny @zeripath @tonivj5 @techknowlogick @GiteaBot