-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7023 - API Org Visibility #7028
Fixes #7023 - API Org Visibility #7028
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7028 +/- ##
=========================================
Coverage ? 41.73%
=========================================
Files ? 443
Lines ? 60159
Branches ? 0
=========================================
Hits ? 25105
Misses ? 31777
Partials ? 3277
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last two nits from me. The description field should describe the body in total but in any case I think it has to be in the referenced schema when there is a reference like that. (I could be wrong - if you want to keep a description just check what other bits do.)
…te/edit and Repo file create/edit/delete
Fixes #7023
Makes sure we are handling visibility when creating and editing orgs as strings. Can be "public", "limited" or "private". Isn't required so if visibility isn't set (empty string) when creating it will be public and when editing it will remain the same.
Update: Did a little clean up of swagger comments and properties for repo Create and Update file endpoints as well since didn't know that comments could be put in the struct and seen by clicking "Model" on the swagger page until recently.