Add work path CLI option #6922
Merged
Add work path CLI option #6922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it possible to set the work path as a CLI option instead of relying on environment variables which are somewhat opaque
zeripath
added
topic/deployment
type/docs
techknowlogick
approved these changes
May 12, 2019
GiteaBot
added
the
lgtm/need 1
|
|
|
Sorry this is turning into a game of whack-a-mole... |
Codecov Report
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
+ Coverage 41.4% 41.4% +<.01%
=========================================
Files 441 441
Lines 59729 59732 +3
=========================================
+ Hits 24730 24735 +5
+ Misses 31761 31757 -4
- Partials 3238 3240 +2
Continue to review full report at Codecov.
|
adelowo
approved these changes
May 14, 2019
GiteaBot
added
lgtm/done
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
Makes it possible to set the work path as a CLI option instead of relying on environment variables which are somewhat opaque
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #6855 the use of environment variables to configure gitea - although common practice - is confusing and frustrating for non-docker users. Environment variables are somewhat opaque to most users and can't easily be inferred from the command.
This PR adds a new option to the main command-line allowing you to set the work-path, overriding the GITEA_WORK_DIR variable and build defined AppWorkDir as necessary.