Escape the commit message on issues update and title in telegram hook #6901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
added
backport/v1.8
type/refactoring
techknowlogick
approved these changes
May 10, 2019
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
May 10, 2019
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #6901 +/- ##
==========================================
+ Coverage 41.41% 41.42% +<.01%
==========================================
Files 432 432
Lines 59541 59541
==========================================
+ Hits 24658 24663 +5
+ Misses 31644 31638 -6
- Partials 3239 3240 +1
Continue to review full report at Codecov.
|
|
Please send backport |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 10, 2019
zeripath
added a commit
that referenced
this pull request
May 10, 2019
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 11, 2019
techknowlogick
pushed a commit
that referenced
this pull request
May 11, 2019
* Add options to git.Clone to make it more capable * Begin the process of removing the local copy and tidy up * Remove Wiki LocalCopy Checkouts * Remove the last LocalRepo helpers * Remove WithTemporaryFile * Enable push-hooks for these routes * Ensure tests cope with hooks Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove Repository.LocalCopyPath() * Move temporary repo to use the standard temporary path * Fix the tests Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove LocalWikiPath * Fix missing remove Signed-off-by: Andrew Thornton <art27@cantab.net> * Use AppURL for Oauth user link (#6894) * Use AppURL for Oauth user link Fix #6843 * Update oauth.go * Update oauth.go * internal/ssh: ignore env command totally (#6825) * ssh: ignore env command totally * Remove commented code Needed fix described in issue #6889 * Escape the commit message on issues update and title in telegram hook (#6901) * update sdk to latest (#6903) * improve description of branch protection (fix #6886) (#6906) The branch protection description text were not quite accurate. * Fix logging documentation (#6904) * ENABLE_MACARON_REDIRECT should be REDIRECT_MACARON_LOG * Allow DISABLE_ROUTER_LOG to be set in the [log] section * [skip ci] Updated translations via Crowdin * Move sdk structs to modules/structs (#6905) * move sdk structs to moduels/structs * fix tests * fix fmt * fix swagger * fix vendor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit message was not properly being escaped when being referenced in an issue, neither was the issue title escaped in the telegram webhook.
Fortunately the commit message was passed through a sanitiser but it is still possible to corrupt the page structure.