Allow Recaptcha service url to be configured #6820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
approved these changes
May 1, 2019
GiteaBot
added
the
lgtm/need 1
techknowlogick
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #6820 +/- ##
==========================================
+ Coverage 41.21% 41.22% +<.01%
==========================================
Files 421 421
Lines 58118 58124 +6
==========================================
+ Hits 23955 23959 +4
- Misses 30989 30993 +4
+ Partials 3174 3172 -2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 1
silverwind
reviewed
May 2, 2019
| @@ -23,11 +24,11 @@ type Response struct { | |||
| ErrorCodes []string `json:"error-codes"` | |||
| } | |||
|
|
|||
| const apiURL = "https://www.google.com/recaptcha/api/siteverify" | |||
| const apiURL = "/api/siteverify" | |||
There was a problem hiding this comment.
Why not make the whole URL configurable?
There was a problem hiding this comment.
You'd need to have multiple URLs. The api.js and verify URL.
Can do it if wanted
There was a problem hiding this comment.
Ah, okay. It's fine the way it is then.
jonasfranz
approved these changes
May 2, 2019
GiteaBot
added
lgtm/done
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6818