[API] Load issue attributes when editing an issue #6723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
adelowo
approved these changes
Apr 23, 2019
GiteaBot
added
the
lgtm/need 1
|
Nice catch... We really need more tests for the api handlers |
techknowlogick
approved these changes
Apr 23, 2019
GiteaBot
added
lgtm/done
|
@jolheiser thanks for PR :) I'll be merging this once build is complete, could you create a backport PR once I merge this one? |
|
@techknowlogick Sure thing! 😄 |
Codecov Report
@@ Coverage Diff @@
## master #6723 +/- ##
==========================================
+ Coverage 40.72% 40.73% +0.01%
==========================================
Files 421 421
Lines 57867 57872 +5
==========================================
+ Hits 23567 23575 +8
+ Misses 31171 31167 -4
- Partials 3129 3130 +1
Continue to review full report at Codecov.
|
|
Please create backport to 1.8 branch |
jolheiser
added a commit
to jolheiser/gitea
that referenced
this pull request
Apr 23, 2019
techknowlogick
added
the
backport/done
lafriks
pushed a commit
that referenced
this pull request
Apr 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6721
Previously assignees on the issue were nil since they weren't loaded, which messed up any ranging that happened when comparing.