Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder file actions #6706

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Reorder file actions #6706

merged 3 commits into from
Apr 24, 2019

Conversation

webjoel
Copy link
Contributor

@webjoel webjoel commented Apr 22, 2019

Currently the ordering of the file actions in Gitea is different from the ordering of the same actions in GitHub.

To improve the usability, since they are the same actions, I am sending this PR to leave equal in the two tools, Gitea and GiHub.

Follow the images for comparison:

GitHub:
github

Actual Gitea:
gitea

New Gitea:
giteaAfterPR

@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #6706 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6706      +/-   ##
==========================================
- Coverage   40.73%   40.73%   -0.01%     
==========================================
  Files         421      421              
  Lines       57872    57872              
==========================================
- Hits        23576    23572       -4     
- Misses      31168    31171       +3     
- Partials     3128     3129       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
routers/repo/view.go 41.6% <0%> (-1.01%) ⬇️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45fa5cc...ed9381a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 22, 2019
@lafriks
Copy link
Member

lafriks commented Apr 22, 2019

I would actually prefer Raw | History | Blame

@lafriks lafriks added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Apr 22, 2019
@webjoel
Copy link
Contributor Author

webjoel commented Apr 22, 2019

@lafriks I suggested this order because I use GitHub a lot, as well as Gitea, so I'm sometimes confused, since they are the same actions.

@lafriks
Copy link
Member

lafriks commented Apr 22, 2019

Yes me too but I use History more than Blame :P

@lunny
Copy link
Member

lunny commented Apr 23, 2019

@lafriks I will agree with @webjoel and I think this is also suitable for you. Since you use history more than blame, put it on the right maybe better? :)

@lafriks
Copy link
Member

lafriks commented Apr 23, 2019

I'm in no way requesting that change I'm ok also with GitHub order :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 23, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 23, 2019
@lafriks lafriks added topic/ui Change the appearance of the Gitea UI and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Apr 23, 2019
@lafriks lafriks changed the title Order file actions equal to GitHub Reorder file actions Apr 23, 2019
@lunny lunny added this to the 1.9.0 milestone Apr 24, 2019
@lunny lunny merged commit 67c91e1 into go-gitea:master Apr 24, 2019
@webjoel webjoel deleted the reorder_file_actions branch May 5, 2019 13:41
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants