Skip to content

Conversation

@jonasfranz
Copy link
Member

This PR adds the ability of revoking access for certain application via the settings UI.

Screenshots:

Screenshot_2019-04-15 Gitea Git with a cup of tea

jonasfranz and others added 3 commits April 15, 2019 08:46
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Add translations

Signed-off-by: Jonas Franz <info@jonasfranz.software>
@jonasfranz jonasfranz added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 15, 2019
@jonasfranz jonasfranz added this to the 1.9.0 milestone Apr 15, 2019
jonasfranz and others added 2 commits April 15, 2019 09:17
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Signed-off-by: Jonas Franz <info@jonasfranz.software>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 15, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 15, 2019
@codecov-io
Copy link

codecov-io commented Apr 15, 2019

Codecov Report

Merging #6625 into master will increase coverage by <.01%.
The diff coverage is 54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6625      +/-   ##
==========================================
+ Coverage   40.75%   40.76%   +<.01%     
==========================================
  Files         407      407              
  Lines       54680    54730      +50     
==========================================
+ Hits        22284    22308      +24     
- Misses      29344    29368      +24     
- Partials     3052     3054       +2
Impacted Files Coverage Δ
routers/user/setting/oauth2.go 0% <0%> (ø) ⬆️
routers/routes/routes.go 81.99% <100%> (+0.02%) ⬆️
routers/user/setting/applications.go 45.61% <20%> (-2.47%) ⬇️
models/oauth2_application.go 58.78% <80.64%> (+2.73%) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3454836...833e03d. Read the comment docs.

Use results.Close()

Signed-off-by: Jonas Franz <info@jonasfranz.software>
@jonasfranz jonasfranz requested a review from lunny April 15, 2019 20:30
@jonasfranz jonasfranz requested a review from lunny April 16, 2019 07:39
jonasfranz and others added 2 commits April 17, 2019 08:33
Signed-off-by: Jonas Franz <info@jonasfranz.software>
@jonasfranz jonasfranz requested a review from lunny April 17, 2019 06:33
@lunny
Copy link
Member

lunny commented Apr 17, 2019

@jonasfranz I mean ctx.QueryInt64("id") maybe zero, but not ctx.User.ID. If ctx.QueryInt64("id") is zero will delete all grants.

Signed-off-by: Jonas Franz <info@jonasfranz.software>
@jonasfranz
Copy link
Member Author

@lunny fixed

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 17, 2019
@lunny lunny merged commit 7a4c29c into go-gitea:master Apr 17, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants