fix Open Graph og:image link #6612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6612 +/- ##
=========================================
Coverage ? 40.47%
=========================================
Files ? 406
Lines ? 54484
Branches ? 0
=========================================
Hits ? 22054
Misses ? 29393
Partials ? 3037Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
previously requested changes
Apr 14, 2019
jonasfranz
approved these changes
Apr 14, 2019
GiteaBot
added
lgtm/need 1
kolaente
approved these changes
Apr 14, 2019
GiteaBot
added
lgtm/done
|
@ashimokawa Please check "allow edits from maintainers" so we can merge latest changes from master before merging. |
Codeberg-org
force-pushed
the
fix-opengraph-imagelink
branch
from
32a620f
to
ee49fc3
Compare
Done, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Open Graph og:image link, which fix fix twitter preview cards, among others
you can see the problem by using this link, and then clicking on the "Open Graph" button:
http://debug.iframely.com/?uri=https://try.gitea.io
Or use the twitter card validator
https://cards-dev.twitter.com/validator
Corresponding Codeberg issue: https://codeberg.org/Codeberg/Community/issues/39