Skip to content

Notifications: trying to get a better layout #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 18, 2017
Merged

Notifications: trying to get a better layout #660

merged 6 commits into from
Jan 18, 2017

Conversation

@andreynering
Copy link
Contributor

@andreynering andreynering commented Jan 12, 2017

I'm not an UI guy, so feedback welcome.

Screenshot

@andreynering andreynering added topic/ui Change the appearance of the Gitea UI pr/wip This PR is not ready for review labels Jan 12, 2017
@andreynering andreynering added this to the 1.1.0 milestone Jan 12, 2017
@appleboy
Copy link
Member

appleboy commented Jan 13, 2017

@andreynering Could your provide origin screenshot?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 13, 2017
@Bwko
Copy link
Member

Bwko commented Jan 13, 2017

@appleboy Current situation:
current-notifiactions

@andreynering Looks good 👍 , LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 13, 2017
@lunny
Copy link
Member

lunny commented Jan 13, 2017

@Bwko it's still wip

@Bwko
Copy link
Member

Bwko commented Jan 13, 2017

@lunny I know but it looks good enough to me. Only the bell icon is slightly off-center
untitled

@appleboy
Copy link
Member

appleboy commented Jan 13, 2017

origin screenshot:

screen shot 2017-01-13 at 9 56 30 pm

@andreynering andreynering removed the pr/wip This PR is not ready for review label Jan 17, 2017
@andreynering
Copy link
Contributor Author

andreynering commented Jan 17, 2017

This is done to be merged.

@andreynering andreynering mentioned this pull request Jan 17, 2017
Merged
@lunny
Copy link
Member

lunny commented Jan 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 18, 2017
@lunny lunny merged commit d2bb8ef into go-gitea:master Jan 18, 2017
@andreynering andreynering deleted the notifications-step-4 branch February 4, 2017 12:45
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@andreynering @appleboy @Bwko @lunny @tboerger