Add username flag in create-user command

[ngourdon]

Ensure consistency of name/username flags between create-user and change-password commands

• Add username flag in create-user command
• Deprecate name flag in create-user command

fix #6174

[codecov-io]

Codecov Report

Merging #6534 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6534      +/-   ##
==========================================
- Coverage   40.35%   40.34%   -0.01%     
==========================================
  Files         405      405              
  Lines       54251    54251              
==========================================
- Hits        21895    21890       -5     
- Misses      29340    29345       +5     
  Partials     3016     3016

Impacted Files	Coverage Δ
modules/log/event.go	64.46% <0%> (-1.53%)	⬇️
models/repo_list.go	66.84% <0%> (-1.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e949db...8606fdd. Read the comment docs.

[lafriks]

Not

Suggested change

	return errors.New("One of --name and --username flags must be set")
	return errors.New("One of --name or --username flags must be set")

[mrsdizzie]

docs/content/doc/usage/command-line.en-us.md should be updated as part of this PR as well to document the change (probably fine to just change name to username there)

[mrsdizzie]

Hmm actually, since this is tagged 1.9.0 the docs should probably include mention of both options since they aren't versioned at all (I forget!). People downloading a current release wouldn't have access to this change. Maybe something like "As of gitea 1.9.0, use the --username flag instead"

[ngourdon]

If I understand well, the doc on gitea.io comes from the master branch.
I will improve the doc as you say to be fine for both versions.

Something like
--name value: Username. Required. As of gitea 1.9.0, use the --username flag instead
--username value: Username. Required. New in gitea 1.9.0

And for the example, keeping the --name flag and adding a comment
gitea admin create-user --name myname --password asecurepassword --email me@example.com
As of gitea 1.9.0, use the --username flag instead

[ngourdon]

Do you want me to squash commits to clean history before merging ?

[techknowlogick]

@ngourdon oh no. Don’t worry about that, we will do that. Thanks for PR :)

[ngourdon]

My pleasure 😄
Thanks to you all.