-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Unifies pagination template usage (#6531) #6533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unifies pagination template usage (#6531) #6533
Conversation
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
218c9f9
to
0a5195e
Compare
Codecov Report
@@ Coverage Diff @@
## master #6533 +/- ##
=========================================
Coverage ? 40.83%
=========================================
Files ? 419
Lines ? 57340
Branches ? 0
=========================================
Hits ? 23413
Misses ? 30804
Partials ? 3123
Continue to review full report at Codecov.
|
There's a Conflict with a commit in master. Otherwise this now looks good |
7cccc57
to
3184884
Compare
Co-Authored-By: saitho <mario.lubenka@googlemail.com>
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
…ation # Conflicts: # routers/repo/commit.go
This pull request makes the additional URL params that are used in the pagination template configurable. This enables the usage of the same template among all pages that use a pagination.
Resolves #6531.
How to test
Check the paginations on all pages that use one, i.e. templates with
{{template "base/paginate" .}}