Skip to content

Unifies pagination template usage (#6531) #6533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 20, 2019

Conversation

saitho
Copy link
Contributor

@saitho saitho commented Apr 7, 2019

This pull request makes the additional URL params that are used in the pagination template configurable. This enables the usage of the same template among all pages that use a pagination.

Resolves #6531.


How to test

Check the paginations on all pages that use one, i.e. templates with {{template "base/paginate" .}}

@saitho saitho changed the title Unifies pagination template usage (#6531) [WIP] Unifies pagination template usage (#6531) Apr 7, 2019
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 13, 2019
saitho added 2 commits April 13, 2019 13:23
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
@saitho saitho force-pushed the feature/unify_pagination branch from 218c9f9 to 0a5195e Compare April 13, 2019 12:23
@codecov-io
Copy link

codecov-io commented Apr 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@40dc458). Click here to learn what that means.
The diff coverage is 69.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6533   +/-   ##
=========================================
  Coverage          ?   40.83%           
=========================================
  Files             ?      419           
  Lines             ?    57340           
  Branches          ?        0           
=========================================
  Hits              ?    23413           
  Misses            ?    30804           
  Partials          ?     3123
Impacted Files Coverage Δ
routers/repo/view.go 41.6% <0%> (ø)
routers/admin/notice.go 0% <0%> (ø)
routers/repo/milestone.go 0% <0%> (ø)
routers/repo/issue.go 37.09% <100%> (ø)
modules/context/pagination.go 100% <100%> (ø)
routers/repo/search.go 60.71% <100%> (ø)
routers/user/notification.go 48.27% <100%> (ø)
routers/repo/release.go 33.9% <100%> (ø)
modules/context/api.go 49% <22.22%> (ø)
routers/repo/commit.go 25% <50%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40dc458...94a3a83. Read the comment docs.

@saitho saitho changed the title [WIP] Unifies pagination template usage (#6531) Unifies pagination template usage (#6531) Apr 13, 2019
@saitho saitho marked this pull request as ready for review April 13, 2019 12:50
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 16, 2019
@zeripath
Copy link
Contributor

There's a Conflict with a commit in master.

Otherwise this now looks good

@saitho saitho force-pushed the feature/unify_pagination branch from 7cccc57 to 3184884 Compare April 17, 2019 18:36
Co-Authored-By: saitho <mario.lubenka@googlemail.com>
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 18, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 18, 2019
saitho added 3 commits April 19, 2019 13:39
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com>
@techknowlogick techknowlogick requested a review from lunny April 19, 2019 15:07
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2019
@techknowlogick techknowlogick merged commit fcbac38 into go-gitea:master Apr 20, 2019
@saitho saitho deleted the feature/unify_pagination branch April 28, 2019 10:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unified pagination template
7 participants