Add golangci

[kolaente]

This pr adds golangci to Gitea and replaces some linters (which golangci contains). This will (hopefully) enhance code quality.

Golangci lint calls a lot of golang lint tools directly, which make it a lot faster.

[kolaente]

Looks like the new ci step works, now we just have to fix all the issues.

[kolaente]

Fixed most of the issues, however there are some issues where I don't really know what to do:

• [ ]

modules/indexer/issues/indexer.go:95:32: Error return value of `issueIndexerUpdateQueue.Run` is not checked (errcheck)
        go issueIndexerUpdateQueue.Run()
                                      ^

It looks like issueIndexerUpdateQueue.Run() doesn't return an error in any of its implementations. Could we just remove the error return?

• Fixed from the hint by @lunny.

models/git_diff.go:387:2: S1001: should use copy() instead of a loop (gosimple)
        for idx, lof := range hunk[:headerLines] {
        ^

I don't know how it is possible to let copy only copy some parts of a slice.

• Done

models/repo_list.go:149:2: SA9004: only the first constant in this group has an explicit type (staticcheck)
        SearchOrderByAlphabetically        SearchOrderBy = "name ASC"
        ^

I don't really think this is an issue... or is it?

• @jonasfranz said the check isn't needed at all, so I removed it completly.

routers/user/oauth.go:166:2: SA4006: this value of `errs` is never used (staticcheck)
        errs = form.Validate(ctx.Context, errs)
        ^

If the errors are not checked, can the whole check be removed? Or how can we check for the error?

[lunny]

@kolaente Is golangci support gitea? Since we will host gitea on gitea.com. If golangci don't support gitea, it will not work.

[kolaente]

@lunny It's just a binary file which runs locally and in drone. Since we run it on our own infrastructure, we're not tied to a particular platform.

IIRC they offer tight ingration with github (things like having a bot which comments on the pr instead of just failing the pipeline) which we won't have. But I see no problem with it just failing the pipeline.

[kolaente]

Just merged with Gitea's master, it did containt a lot of new issues which had to be fixed...

[sapk]

That a lot of missed error checking and more could still be logged in goroutine or defer. This will really improve the codebase and review.
LGTM, I would suggest to disable most of the linter that still failed and manage to enable them one at a time in separates PRs. This will ease the process of review and limit the number of conflict appearing.

[sapk]

Found one template file to be removed

[kolaente]

@sapk I think we need to enable these now, I doubt there will be other prs soon otherwise...

[zeripath]

thanks @kolaente !

[lunny]

conflicted

[kolaente]

@lunny fixed.

[kolaente]

@lunny @sapk please approve.

[lunny]

This function should return error as second return parameter I think.

[kolaente]

The problem is it is called in SendAsync which just puts the mail in a queue to be sent. There's not much room for error handling there.

[lunny]

Or we have to return nil here, otherwise it may panic when invoke issue.Repo.HTMLURL().

[kolaente]

The problem with this function is the error could never really be handled appropriatly. It would only be bubbled up to then be logged.
I would prefer to leave it as it is, to not having to deal with more complexty bubbling the error up would bring.