Add pid flag to serve and don't set pid by default #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleboy
approved these changes
Jan 11, 2017
|
Otherwise LGTM. |
tboerger
added
the
lgtm/need 1
appleboy
suggested changes
Jan 11, 2017
| }, cli.StringFlag{ | ||
| Name: "pid, P", | ||
| Value: "/var/run/gitea.pid", | ||
| Usage: "Custom pid file path", | ||
| }, |
There was a problem hiding this comment.
git serve don't need pid argument ?
appleboy
approved these changes
Jan 11, 2017
tboerger
reviewed
Jan 13, 2017
| @@ -62,7 +62,7 @@ and it takes care of all the other things for you`, | |||
| }, | |||
| cli.StringFlag{ | |||
| Name: "pid, P", | |||
| Value: "custom/run/app.pid", | |||
| Value: "/var/run/gitea.pid", | |||
There was a problem hiding this comment.
Why changing the current default?
There was a problem hiding this comment.
/var/run/ Is the normal location for pid files
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the pid bug of #635