-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Username and Orgname MaxSize 35 -> 40 #6178
Increase Username and Orgname MaxSize 35 -> 40 #6178
Conversation
Signed-off-by: Segev Finer <segev@codeocean.com>
Codecov Report
@@ Coverage Diff @@
## master #6178 +/- ##
=========================================
Coverage ? 38.88%
=========================================
Files ? 354
Lines ? 50184
Branches ? 0
=========================================
Hits ? 19516
Misses ? 27842
Partials ? 2826
Continue to review full report at Codecov.
|
Please update the dep file with latest commit from sdk :) |
Signed-off-by: Segev Finer <segev@codeocean.com>
Done. |
6f4a18f
to
2e03720
Compare
Signed-off-by: Segev Finer <segev@codeocean.com>
2e03720
to
b312538
Compare
Change the
MaxSize
limit from 35 to 40 for theUsername
andOrgname
fields. Our system uses GUID/UUID names and we needed a slightly larger limit for those fields. The DB schema already usesVARCHAR(255)
from a default in xorm (http://gobook.io/read/github.com/go-xorm/manual-en-US/chapter-02/1.mapping.html).Depends on go-gitea/go-sdk#149 (I haven't updated it in
dep
so that needs to be done once that PR is merged)