Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Username and Orgname MaxSize 35 -> 40 #6178

Merged
merged 4 commits into from
Feb 25, 2019

Conversation

segevfiner
Copy link
Contributor

Change the MaxSize limit from 35 to 40 for the Username and Orgname fields. Our system uses GUID/UUID names and we needed a slightly larger limit for those fields. The DB schema already uses VARCHAR(255) from a default in xorm (http://gobook.io/read/github.com/go-xorm/manual-en-US/chapter-02/1.mapping.html).

Depends on go-gitea/go-sdk#149 (I haven't updated it in dep so that needs to be done once that PR is merged)

Signed-off-by: Segev Finer <segev@codeocean.com>
@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@795f6e0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6178   +/-   ##
=========================================
  Coverage          ?   38.88%           
=========================================
  Files             ?      354           
  Lines             ?    50184           
  Branches          ?        0           
=========================================
  Hits              ?    19516           
  Misses            ?    27842           
  Partials          ?     2826
Impacted Files Coverage Δ
modules/auth/org.go 0% <ø> (ø)
modules/auth/user_form.go 41.81% <ø> (ø)
modules/auth/user_form_auth_openid.go 0% <ø> (ø)
modules/auth/admin.go 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795f6e0...9f95117. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 25, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 25, 2019
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Feb 25, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2019
@techknowlogick
Copy link
Member

Please update the dep file with latest commit from sdk :)

Signed-off-by: Segev Finer <segev@codeocean.com>
@segevfiner
Copy link
Contributor Author

Please update the dep file with latest commit from sdk :)

Done.

Signed-off-by: Segev Finer <segev@codeocean.com>
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 25, 2019
@techknowlogick techknowlogick merged commit 594f591 into go-gitea:master Feb 25, 2019
@segevfiner segevfiner deleted the username-orgname-max-size branch February 25, 2019 19:03
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants