Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix scrollbar always present on page body #6177

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

silverwind
Copy link
Member

28fcbf3 had reintroduced a small issue where the main page scrollbar was present even if there was no real scrollable content. To fix, I changed the height of the footer to flex-basis which works better than height, which fixes the issue in all Browsers except IE 11 where I had to additionally set the overflow on body to auto to display scrollbars only when needed.

@codecov-io
Copy link

Codecov Report

Merging #6177 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6177   +/-   ##
=======================================
  Coverage   38.87%   38.87%           
=======================================
  Files         354      354           
  Lines       50184    50184           
=======================================
  Hits        19508    19508           
  Misses      27851    27851           
  Partials     2825     2825

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28fcbf3...5f16489. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 25, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 25, 2019
@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 25, 2019
@lafriks lafriks added this to the 1.8.0 milestone Feb 25, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2019
@lafriks lafriks merged commit d8d24a5 into go-gitea:master Feb 25, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants