Skip to content

Split setting.go as multiple files #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2019
Merged

Split setting.go as multiple files #6014

merged 3 commits into from
Feb 10, 2019

Conversation

@lunny
Copy link
Member

@lunny lunny commented Feb 9, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 9, 2019
@lunny lunny added this to the 1.8.0 milestone Feb 9, 2019
@lunny lunny force-pushed the lunny/split_setting branch from 299d988 to 1eecf2a Compare February 9, 2019 06:51
@codecov-io
Copy link

codecov-io commented Feb 9, 2019 •
edited
Loading

Codecov Report

Merging #6014 into master will decrease coverage by <.01%.
The diff coverage is 60.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6014      +/-   ##
==========================================
- Coverage   38.73%   38.72%   -0.01%     
==========================================
  Files         332      338       +6     
  Lines       48994    48994              
==========================================
- Hits        18978    18975       -3     
- Misses      27269    27271       +2     
- Partials     2747     2748       +1
Impacted Files Coverage Δ
modules/setting/setting.go 47.68% <ø> (-4.22%) ⬇️
modules/setting/webhook.go 100% <100%> (ø)
modules/setting/session.go 100% <100%> (ø)
modules/setting/mailer.go 50% <50%> (ø)
modules/setting/log.go 51.93% <51.93%> (ø)
modules/setting/cache.go 73.33% <73.33%> (ø)
modules/setting/service.go 76.74% <76.74%> (ø)
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8cc3b...4fd4cfe. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 9, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 9, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 9, 2019
@lunny lunny merged commit 820e28c into go-gitea:master Feb 10, 2019
@lunny lunny deleted the lunny/split_setting branch February 10, 2019 01:37
@lunny
Copy link
Member Author

lunny commented Jun 13, 2019

partially fix #3917

@snyk-bot snyk-bot mentioned this pull request Jul 10, 2020
Open
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lunny @codecov-io @appleboy @lafriks @GiteaBot @zeripath