Support n as a line highlight prefix #5987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're working on rolling out gitea as a replacement for a fairly large cgit installation. Part of this involves a metric ton of mod_rewrite rules so that links people have out in the wild will still work. Unfortunately, cgit uses #n1 in the url to indicate a single line highlight, which doesn't get passed to the server and therefore can't be rewritten. We've got a local workaround by shoving a script block into a custom header template, but thought it might be nicer to upstream a simple patch to support #n as a prefix for single line highlights. (luckily for simplicity, cgit does not support ranges) Signed-off-by: Monty Taylor <mordred@inaugust.com>
Contributor
Author
|
Incidentally, if landing this upstream isn't cool, no worries. |
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #5987 +/- ##
=======================================
Coverage 38.79% 38.79%
=======================================
Files 330 330
Lines 48729 48729
=======================================
Hits 18904 18904
- Misses 27085 27086 +1
+ Partials 2740 2739 -1
Continue to review full report at Codecov.
|
lafriks
approved these changes
Feb 7, 2019
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Feb 7, 2019
GiteaBot
added
lgtm/done
Member
|
Thanks for PR @emonty |
jeblair
pushed a commit
to jeblair/gitea
that referenced
this pull request
Apr 19, 2019
We're working on rolling out gitea as a replacement for a fairly large cgit installation. Part of this involves a metric ton of mod_rewrite rules so that links people have out in the wild will still work. Unfortunately, cgit uses #n1 in the url to indicate a single line highlight, which doesn't get passed to the server and therefore can't be rewritten. We've got a local workaround by shoving a script block into a custom header template, but thought it might be nicer to upstream a simple patch to support #n as a prefix for single line highlights. (luckily for simplicity, cgit does not support ranges) Signed-off-by: Monty Taylor <mordred@inaugust.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're working on rolling out gitea as a replacement for a fairly
large cgit installation. Part of this involves a metric ton of
mod_rewrite rules so that links people have out in the wild will
still work. Unfortunately, cgit uses #n1 in the url to indicate
a single line highlight, which doesn't get passed to the server
and therefore can't be rewritten.
We've got a local workaround by shoving a script block into a
custom header template, but thought it might be nicer to upstream
a simple patch to support #n as a prefix for single line highlights.
(luckily for simplicity, cgit does not support ranges)
Signed-off-by: Monty Taylor mordred@inaugust.com