Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject empty passwords (#5906) #5908

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Reject empty passwords (#5906) #5908

merged 2 commits into from
Jan 30, 2019

Conversation

zeripath
Copy link
Contributor

Backport #5906

@techknowlogick techknowlogick added this to the 1.7.1 milestone Jan 30, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 30, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2019
@zeripath
Copy link
Contributor Author

Something strange happened to mssql in the build - I've restarted it.

@techknowlogick
Copy link
Member

@zeripath 😂 I restarted it too. I've cancelled mine, so now just one is running.

@zeripath
Copy link
Contributor Author

Of course now it has to start again...

@lafriks lafriks merged commit e5af93a into go-gitea:release/v1.7 Jan 30, 2019
@zeripath zeripath deleted the reject-empty-passwords branch January 30, 2019 22:57
@lafriks lafriks added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Jan 31, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @techknowlogick @lafriks @GiteaBot