Skip to content

Fix an error while adding a dependency via UI. #5862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2019
Merged

Fix an error while adding a dependency via UI. #5862

merged 2 commits into from
Jan 27, 2019

Conversation

@HarshitOnGitHub
Copy link
Contributor

@HarshitOnGitHub HarshitOnGitHub commented Jan 26, 2019

We were not checking if the Repo attribute is loaded or not before using it.

image

Fixes: #5783.

@codecov-io
Copy link

codecov-io commented Jan 26, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2d8520d). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5862   +/-   ##
=========================================
  Coverage          ?   37.85%           
=========================================
  Files             ?      328           
  Lines             ?    48326           
  Branches          ?        0           
=========================================
  Hits              ?    18292           
  Misses            ?    27401           
  Partials          ?     2633
Impacted Files Coverage Δ
models/issue_comment.go 46% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d8520d...d7102c8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 26, 2019
zeripath
zeripath suggested changes Jan 26, 2019
View reviewed changes
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 27, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 27, 2019
@zeripath
Copy link
Contributor

zeripath commented Jan 27, 2019

Thanks @HarshitOnGitHub

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2019
@lafriks lafriks merged commit 7e8242d into go-gitea:master Jan 27, 2019
bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019
@HarshitOnGitHub @bmackinney
Fix an error while adding a dependency via UI. (go-gitea#5862)
dcf5efc 
Fixes: go-gitea#5783
@lunny
Copy link
Member

lunny commented Jan 28, 2019

@HarshitOnGitHub could you send a backport to release/v1.7?

@HarshitOnGitHub
Copy link
Contributor Author

HarshitOnGitHub commented Jan 28, 2019

@lunny Done.

zeripath pushed a commit that referenced this pull request Jan 28, 2019
@HarshitOnGitHub @zeripath
Fix an error while adding a dependency via UI. (Backport #5862) (#5876)
d3a334d 
Fixes: #5783.
@adelowo
Copy link
Member

adelowo commented Jan 28, 2019

@zeripath Can you add backport/done label

@zeripath zeripath added the backport/done All backports for this PR have been created label Jan 28, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zeripath zeripath zeripath approved these changes

@kolaente kolaente kolaente approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

Cannot add issue/pull dependencies

9 participants

@HarshitOnGitHub @codecov-io @zeripath @lunny @adelowo @kolaente @techknowlogick @lafriks @GiteaBot