Fix TLS errors when using acme/autocert for local connections (#5820) #5826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
approved these changes
Jan 24, 2019
bkcsoft
added
the
lgtm/need 1
lafriks
approved these changes
Jan 24, 2019
bkcsoft
added
lgtm/done
|
Thanks @joohoi for your work. I wasn't able to setup a suitable test environment but I hope that my code diving was helpful in pointing you to where your needed to fix this. |
lafriks
changed the title
It totally was! I made a wrong assumption in the initial issue, and the resulting fix would have taken quite a bit longer without the pointers, thanks! This was my first look into Gitea codebase altogether. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5820