Skip to content

When creating new repository fsck option should be enabled #5817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2019
Merged

When creating new repository fsck option should be enabled #5817

merged 2 commits into from
Jan 24, 2019

Conversation

@lafriks
Copy link
Member

@lafriks lafriks commented Jan 23, 2019

Fixes #5810

@lafriks lafriks added this to the 1.8.0 milestone Jan 23, 2019
@codecov-io
Copy link

codecov-io commented Jan 23, 2019 •
edited
Loading

Codecov Report

Merging #5817 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5817      +/-   ##
==========================================
+ Coverage   37.87%   37.92%   +0.04%     
==========================================
  Files         328      328              
  Lines       48255    48256       +1     
==========================================
+ Hits        18276    18299      +23     
+ Misses      27350    27328      -22     
  Partials     2629     2629
Impacted Files Coverage Δ
models/repo.go 43.84% <100%> (+0.03%) ⬆️
modules/indexer/repo.go 68.7% <0%> (+5.34%) ⬆️
models/repo_indexer.go 50% <0%> (+5.5%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b36402...e43a55b. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 23, 2019
@lafriks lafriks force-pushed the fix/fsck_enabled_by_default branch from beed3f6 to 429439c Compare January 23, 2019 23:26
@lafriks lafriks force-pushed the fix/fsck_enabled_by_default branch from 429439c to 6b58b6e Compare January 23, 2019 23:27
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2019
@techknowlogick techknowlogick merged commit 386e531 into go-gitea:master Jan 24, 2019
@techknowlogick
Copy link
Member

techknowlogick commented Jan 24, 2019

@lafriks please backport 😄

@lafriks lafriks deleted the fix/fsck_enabled_by_default branch January 24, 2019 07:08
bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019
@lafriks @bmackinney
When creating new repository fsck option should be enabled (go-gitea#…
bbc3e3c 
…5817)
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Jan 28, 2019
@lafriks
When creating new repository fsck option should be enabled (go-gitea#…
66d8c11 
…5817)
@lafriks lafriks mentioned this pull request Jan 28, 2019
Merged
lunny pushed a commit that referenced this pull request Jan 29, 2019
@lafriks @lunny
When creating new repository fsck option should be enabled (#5817) (#…
4fe1a30 
…5885)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

Health check is disabled by default

5 participants

@lafriks @codecov-io @techknowlogick @zeripath @bkcsoft