fix public will not be reused as public key after deleting as deploy key #5671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5671 +/- ##
=========================================
Coverage ? 37.77%
=========================================
Files ? 323
Lines ? 47595
Branches ? 0
=========================================
Hits ? 17977
Misses ? 27029
Partials ? 2589
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
zeripath
approved these changes
Jan 9, 2019
Contributor
zeripath
left a comment
zeripath
left a comment
There was a problem hiding this comment.
Oh dear, I think I've looked at this code before and wondered why it didn't need to rewrite the public keys! Turns out it did!!
bkcsoft
added
lgtm/need 1
Member
Author
|
@zeripath I just take a look and found the problem. Sorry to post a PR before you! :) |
Contributor
|
No probs, as I said, I saw it and ignored it. That'll teach me! I think I may just need to be more suspicious. |
adelowo
approved these changes
Jan 9, 2019
bkcsoft
added
lgtm/done
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jan 10, 2019
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jan 10, 2019
techknowlogick
pushed a commit
that referenced
this pull request
Jan 10, 2019
techknowlogick
pushed a commit
that referenced
this pull request
Jan 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #1357