Skip to content

Conversation

@nephatrine
Copy link
Contributor

I opened issue #5595 after experiencing a hang while updating to a new gitea version during db migration protecting the scratch tokens. On the advice of user @typeless this incredibly simple change resolved the issue. I did not find any unwanted side effects from this and everything including 2-factor seems to be working on my test gitea instance post-update.

@codecov-io
Copy link

codecov-io commented Dec 31, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@64995ba). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5613   +/-   ##
=========================================
  Coverage          ?   37.53%           
=========================================
  Files             ?      322           
  Lines             ?    47458           
  Branches          ?        0           
=========================================
  Hits              ?    17811           
  Misses            ?    27094           
  Partials          ?     2553
Impacted Files Coverage Δ
models/migrations/v71.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64995ba...d7b1934. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 31, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 31, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 31, 2018
@lunny lunny merged commit b46c279 into go-gitea:master Dec 31, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants