Skip to content

Conversation

@adelowo
Copy link
Member

@adelowo adelowo commented Dec 23, 2018

I was trying to pull #5568 to test it locally. But on trying to add a due date,
I kept on getting "The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'."
Looked at my terminal and it was a panic.

Commit I am running locally : a06ae0b

Log --> https://gist.github.com/adelowo/d74a006e9d77d6be6fa41a50a5e09008

@codecov-io
Copy link

codecov-io commented Dec 23, 2018

Codecov Report

Merging #5587 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5587      +/-   ##
==========================================
+ Coverage   37.52%   37.52%   +<.01%     
==========================================
  Files         322      322              
  Lines       47283    47286       +3     
==========================================
+ Hits        17741    17746       +5     
+ Misses      26992    26988       -4     
- Partials     2550     2552       +2
Impacted Files Coverage Δ
models/issue_comment.go 46.6% <0%> (-0.18%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
routers/repo/view.go 46.01% <0%> (+1.22%) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82ba73...c5564dc. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 23, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 23, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 26, 2018
@rvillablanca
Copy link
Contributor

Changes have been made so is possible to merge this PR ?

@zeripath
Copy link
Contributor

@rvillablanca - I think @lunny needs to accept your changes. He's on Chinese time (I think) (GMT+8) it's not quite 6am there currently.

@rvillablanca
Copy link
Contributor

Thanks @zeripath, these are not my changes but I need them to make my changes over master branch and not over v1.6.2 tag.

@lafriks lafriks added this to the 1.7.0 milestone Dec 27, 2018
@lafriks
Copy link
Member

lafriks commented Dec 27, 2018

@lunny need your approval

@jonasfranz jonasfranz merged commit 21357a4 into go-gitea:master Dec 27, 2018
@adelowo adelowo deleted the fix_nil_pointer branch December 29, 2018 08:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants