-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nil pointer when adding a due date #5587
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5587 +/- ##
==========================================
+ Coverage 37.52% 37.52% +<.01%
==========================================
Files 322 322
Lines 47283 47286 +3
==========================================
+ Hits 17741 17746 +5
+ Misses 26992 26988 -4
- Partials 2550 2552 +2
Continue to review full report at Codecov.
|
ba94fe6
to
6eb8910
Compare
Changes have been made so is possible to merge this PR ? |
@rvillablanca - I think @lunny needs to accept your changes. He's on Chinese time (I think) (GMT+8) it's not quite 6am there currently. |
Thanks @zeripath, these are not my changes but I need them to make my changes over master branch and not over v1.6.2 tag. |
@lunny need your approval |
I was trying to pull #5568 to test it locally. But on trying to add a due date,
I kept on getting "The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'."
Looked at my terminal and it was a panic.
Commit I am running locally : a06ae0b
Log --> https://gist.github.com/adelowo/d74a006e9d77d6be6fa41a50a5e09008