Remove a double slash in the HTTPS redirection when Let's Encrypt is enabled #5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enabled Before: $ curl 0.0.0.0:3001 <a href="https://gitea.example.com:3000//">Found</a>. After: $ curl 0.0.0.0:3001 <a href="https://gitea.example.com:3000/">Found</a>. Fixes go-gitea#5536
techknowlogick
approved these changes
Dec 12, 2018
bkcsoft
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #5537 +/- ##
=========================================
Coverage ? 37.57%
=========================================
Files ? 319
Lines ? 46949
Branches ? 0
=========================================
Hits ? 17643
Misses ? 26795
Partials ? 2511Continue to review full report at Codecov.
|
lafriks
approved these changes
Dec 12, 2018
bkcsoft
added
lgtm/done
|
Can you please backport to 1.6 branch? |
gregkare
added a commit
to 67P/gitea
that referenced
this pull request
Dec 13, 2018
…th Let's Encrypt Before: $ curl 0.0.0.0:3001 <a href="https://gitea.example.com:3000//">Found</a>. After: $ curl 0.0.0.0:3001 <a href="https://gitea.example.com:3000/">Found</a>. Fixes go-gitea#5536
techknowlogick
pushed a commit
that referenced
this pull request
Dec 13, 2018
… Encrypt (#5539) Before: $ curl 0.0.0.0:3001 <a href="https://gitea.example.com:3000//">Found</a>. After: $ curl 0.0.0.0:3001 <a href="https://gitea.example.com:3000/">Found</a>. Fixes #5536
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Fixes #5536