Skip to content

fix detect force push failure on deletion of protected branches #5522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2018
Merged

fix detect force push failure on deletion of protected branches #5522

merged 3 commits into from
Dec 12, 2018

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 11, 2018

should fix #2631

@lunny lunny added this to the 1.7.0 milestone Dec 11, 2018
@codecov-io
Copy link

codecov-io commented Dec 11, 2018 •
edited
Loading

Codecov Report

Merging #5522 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5522      +/-   ##
==========================================
+ Coverage   37.57%   37.58%   +<.01%     
==========================================
  Files         319      319              
  Lines       46949    46949              
==========================================
+ Hits        17642    17645       +3     
+ Misses      26795    26793       -2     
+ Partials     2512     2511       -1
Impacted Files Coverage Δ
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db7dbd...3cc2d65. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2018
@lafriks lafriks merged commit af6bce3 into go-gitea:master Dec 12, 2018
@lafriks
Copy link
Member

lafriks commented Dec 12, 2018

@lunny please backport

@lunny lunny deleted the lunny/fix_protected_branch_deletion branch December 12, 2018 11:56
lunny added a commit to lunny/gitea that referenced this pull request Dec 12, 2018
@lunny
fix detect force push failure on deletion of protected branches (go-g…
a69d052 
…itea#5522)
@lunny lunny mentioned this pull request Dec 12, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Dec 12, 2018
techknowlogick pushed a commit that referenced this pull request Dec 12, 2018
@lunny @techknowlogick
fix detect force push failure on deletion of protected branches (#5522)…
e6362f3 
… (#5531)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@Bwko Bwko Bwko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

detect force push failure on deletion of protected branches

6 participants

@lunny @codecov-io @lafriks @Bwko @bkcsoft @techknowlogick