Skip to content

fix approvals limitation #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2018
Merged

fix approvals limitation #5521

merged 2 commits into from
Dec 11, 2018

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 11, 2018

@JonasFranzDEV fix bug on #5350 (comment)

@lunny lunny added the type/bug label Dec 11, 2018
@lunny lunny added this to the 1.7.0 milestone Dec 11, 2018
@codecov-io
Copy link

codecov-io commented Dec 11, 2018 •
edited
Loading

Codecov Report

Merging #5521 into master will increase coverage by <.01%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5521      +/-   ##
==========================================
+ Coverage   37.57%   37.58%   +<.01%     
==========================================
  Files         319      319              
  Lines       46947    46949       +2     
==========================================
+ Hits        17642    17645       +3     
+ Misses      26794    26793       -1     
  Partials     2511     2511
Impacted Files Coverage Δ
models/branches.go 43.33% <0%> (ø) ⬆️
routers/repo/issue.go 37.3% <25%> (+0.02%) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c4559...d9fa91b. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2018
@techknowlogick techknowlogick merged commit b1f3685 into go-gitea:master Dec 11, 2018
@lunny lunny deleted the lunny/fix_approvals_limitation branch December 12, 2018 00:17
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jonasfranz jonasfranz jonasfranz approved these changes

@kolaente kolaente kolaente approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

7 participants

@lunny @codecov-io @jonasfranz @kolaente @techknowlogick @bkcsoft @lafriks