Skip to content

Fixing MSSQL timestamp type #5511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2018
Merged

Fixing MSSQL timestamp type #5511

merged 2 commits into from
Dec 11, 2018

Conversation

@chdxD1
Copy link
Contributor

@chdxD1 chdxD1 commented Dec 10, 2018

MSSQL is using the wrong type here which results in a strconv.ParseInt: parsing "2018-12-07T00:00:00Z": invalid syntax error.
The added datediff(SECOND, '19700101', x) results in the unix timestamp to be returned.

This should fix #5328.

@chdxD1
Fixing MSSQL timestamp type
54d454e 
MSSQL is using the wrong type here which results in a strconv.ParseInt: parsing "2018-12-07T00:00:00Z": invalid syntax error.
The added datediff(SECOND, '19700101', x) results in the unix timestamp to be returned.

Signed-off-by: Christopher Dziomba <christopher.dziomba@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 10, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@205a533). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5511   +/-   ##
=========================================
  Coverage          ?   37.62%           
=========================================
  Files             ?      317           
  Lines             ?    46835           
  Branches          ?        0           
=========================================
  Hits              ?    17624           
  Misses            ?    26708           
  Partials          ?     2503
Impacted Files Coverage Δ
models/user_heatmap.go 77.27% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 205a533...dfbbc56. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 10, 2018
@sapk
Copy link
Member

sapk commented Dec 10, 2018

@chdxD1 Thanks for the PR.
@Cellebyte Can you try this solution on your setup ?

@Cellebyte
Copy link

Cellebyte commented Dec 10, 2018

@sapk, @chdxD1 has tested it already on our setup.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 10, 2018
@lunny lunny added the type/bug label Dec 10, 2018
@lunny lunny added this to the 1.7.0 milestone Dec 10, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2018
@lunny lunny merged commit 64680b7 into go-gitea:master Dec 11, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

Heatmap Rendering broken

7 participants

@chdxD1 @codecov-io @sapk @Cellebyte @lunny @lafriks @bkcsoft