Implement pasting image from clipboard for browsers that supports that #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #5317 +/- ##
=========================================
Coverage ? 37.36%
=========================================
Files ? 312
Lines ? 46399
Branches ? 0
=========================================
Hits ? 17339
Misses ? 26576
Partials ? 2484Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
|
It seems it's not work for me. Chrome 70.0.3538.77 on macOS |
|
@lunny do you get any error in JavaScript console? |
|
@lafriks no any error on console. |
|
@lunny can you describe steps you did? |
In Safari there can be both image and text
|
@lunny I just tested and it worked on both chrome and safari on Mac. Try pressing Ctrl+F5 or clearing cache, could be browser was using cached javascript version |
lunny
approved these changes
Nov 14, 2018
bkcsoft
added
lgtm/need 1
techknowlogick
approved these changes
Nov 15, 2018
bkcsoft
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3032
Implemented in new issue text area and when adding issue/pr comments