Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file edit change preview functionality #5300

Merged
merged 2 commits into from
Nov 9, 2018
Merged

Fix file edit change preview functionality #5300

merged 2 commits into from
Nov 9, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Nov 8, 2018

Fixes #5286

@lafriks lafriks added this to the 1.7.0 milestone Nov 8, 2018
@codecov-io
Copy link

codecov-io commented Nov 8, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2852c35). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5300   +/-   ##
=========================================
  Coverage          ?   37.38%           
=========================================
  Files             ?      312           
  Lines             ?    46330           
  Branches          ?        0           
=========================================
  Hits              ?    17322           
  Misses            ?    26527           
  Partials          ?     2481

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2852c35...220bf3b. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 8, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 9, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 9, 2018
@lafriks lafriks merged commit 7dd31eb into go-gitea:master Nov 9, 2018
@lafriks lafriks deleted the fix/edit_change_preview branch November 10, 2018 09:11
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Nov 10, 2018
@lafriks
Fix file edit change preview functionality (go-gitea#5300)
bfadc91
@lafriks lafriks mentioned this pull request Nov 10, 2018
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Nov 10, 2018
lafriks added a commit that referenced this pull request Nov 10, 2018
@lafriks
Fix file edit change preview functionality (#5300) (#5311)
297e619
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bwko Bwko Bwko approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Missing/Erroneous i18n key
5 participants
@lafriks @codecov-io @zeripath @Bwko @bkcsoft