Skip to content

Fix sqlite and mssql lock #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2018
Merged

Fix sqlite and mssql lock #5214

merged 1 commit into from
Oct 29, 2018

Conversation

@lunny
Copy link
Member

@lunny lunny commented Oct 29, 2018

Will fix #4972

@lunny lunny added this to the 1.7.0 milestone Oct 29, 2018
@codecov-io
Copy link

codecov-io commented Oct 29, 2018

Codecov Report

Merging #5214 into master will increase coverage by <.01%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5214      +/-   ##
==========================================
+ Coverage    37.5%   37.51%   +<.01%     
==========================================
  Files         309      309              
  Lines       45820    45827       +7     
==========================================
+ Hits        17183    17190       +7     
  Misses      26176    26176              
  Partials     2461     2461
Impacted Files Coverage Δ
models/org.go 69.05% <89.47%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7694c99...400f0bd. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 29, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 29, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 29, 2018
@techknowlogick techknowlogick merged commit 70a80e3 into go-gitea:master Oct 29, 2018
@lunny lunny deleted the lunny/fix_mssql_sqlite_lock branch October 29, 2018 16:22
lunny added a commit to lunny/gitea that referenced this pull request Oct 29, 2018
@lunny
fix sqlite and mssql lock (go-gitea#5214)
433597b
@lunny lunny mentioned this pull request Oct 29, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Oct 29, 2018
techknowlogick pushed a commit that referenced this pull request Oct 29, 2018
@lunny @techknowlogick
fix sqlite and mssql lock (#5214) (#5218)
7022957
@lunny lunny mentioned this pull request Nov 7, 2018
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

Cannot remove user from organization (MSSQL)

5 participants

@lunny @codecov-io @techknowlogick @sapk @bkcsoft