-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show review summary in pull requests #5132
Conversation
I think it should show only latest grouped by user, also it should skip comment reviews |
@lafriks done. |
Codecov Report
@@ Coverage Diff @@
## master #5132 +/- ##
==========================================
+ Coverage 37.42% 37.44% +0.01%
==========================================
Files 312 312
Lines 46480 46507 +27
==========================================
+ Hits 17396 17414 +18
- Misses 26594 26601 +7
- Partials 2490 2492 +2
Continue to review full report at Codecov.
|
Please add unit tests . |
@JonasFranzDEV done. |
@JonasFranzDEV @kolaente I asked to ignore comment as it is not relevant for approval process as if I reject or approve changes and later do some comment it should still be in state that was previously that I either rejected or approved changes |
@lafriks I see, I'll revert it. |
@lafriks need your review |
offtopic: why do we have |
@lafriks mind approving the pr? |
@kolaente I don't mind ;) |
@lafriks Thanks! |
@kolaente have the eye icon was changed to a tick icon? :) |
Resolves #4390.
This pr implements a review summary on the bottom of a pr as disscussed in #4390.
It currently shows every review grouped by type and user. This means if a user rejects a pr and later approves it, both are shown in the summary (with their dates). Should I keep this behaviour or show only the newest (grouped by user)?
Screenshot