Skip to content

Conversation

@typeless
Copy link
Contributor

In some circumstances, the transaction in the test fixture loading function would rollback when a transaction conflict occurs.
Retry it five times to at least reduce the chance of failures.

@typeless typeless mentioned this pull request Oct 19, 2018
7 tasks
@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #5125 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5125      +/-   ##
=========================================
- Coverage    37.4%   37.4%   -0.01%     
=========================================
  Files         308     308              
  Lines       45605   45612       +7     
=========================================
+ Hits        17057   17059       +2     
- Misses      26091   26094       +3     
- Partials     2457    2459       +2
Impacted Files Coverage Δ
models/test_fixtures.go 100% <100%> (ø) ⬆️
models/repo_indexer.go 50.84% <0%> (-2.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2227446...e323a13. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 19, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 20, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 20, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 20, 2018
@techknowlogick techknowlogick merged commit 583b1b8 into go-gitea:master Oct 20, 2018
@typeless typeless deleted the avoid-rollback branch April 3, 2019 05:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants