Skip to content

Conversation

@cristaloleg
Copy link
Contributor

@cristaloleg cristaloleg commented Oct 19, 2018

Found by go-critic defaultCaseOrder checker

Log:

models/review.go:41:2 defaultCaseOrder consider to make `default` case as first or as last case

@codecov-io
Copy link

Codecov Report

Merging #5119 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5119      +/-   ##
=========================================
+ Coverage    37.4%   37.4%   +<.01%     
=========================================
  Files         307     307              
  Lines       45552   45551       -1     
=========================================
+ Hits        17037   17038       +1     
+ Misses      26060   26058       -2     
  Partials     2455    2455
Impacted Files Coverage Δ
models/review.go 63.3% <100%> (-0.27%) ⬇️
models/repo_indexer.go 52.96% <0%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db3bdc...1e5474c. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 19, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 19, 2018
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 19, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 19, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 19, 2018
@lunny lunny merged commit fef0410 into go-gitea:master Oct 19, 2018
@cristaloleg cristaloleg deleted the gocritic-defaultCaseOrder branch October 19, 2018 13:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants