Skip to content

Fix deadlock when sqlite #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2018
Merged

Fix deadlock when sqlite #5118

merged 3 commits into from
Oct 19, 2018

Conversation

@lunny
Copy link
Member

@lunny lunny commented Oct 19, 2018

fix #5116

@lunny lunny added the type/bug label Oct 19, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 19, 2018
@codecov-io
Copy link

codecov-io commented Oct 19, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@47e4efe). Click here to learn what that means.
The diff coverage is 93.75%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #5118   +/-   ##
========================================
  Coverage          ?   37.4%           
========================================
  Files             ?     307           
  Lines             ?   45553           
  Branches          ?       0           
========================================
  Hits              ?   17038           
  Misses            ?   26060           
  Partials          ?    2455
Impacted Files Coverage Δ
models/wiki.go 62.5% <100%> (ø)
models/repo.go 43.43% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e4efe...cf17e4d. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 19, 2018
@typeless typeless mentioned this pull request Oct 19, 2018
Closed
7 tasks
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 19, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 19, 2018
@techknowlogick techknowlogick merged commit 616b8f4 into go-gitea:master Oct 19, 2018
@lunny lunny deleted the lunny/fix_sqlite_dead_lock branch October 20, 2018 01:29
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

A deadlock code path

6 participants

@lunny @codecov-io @lafriks @sapk @techknowlogick @bkcsoft