Fix regex to support optional end line of old section in diff hunk #5096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Named groups in reges for easier group parsing
jonasfranz
approved these changes
Oct 17, 2018
bkcsoft
added
the
lgtm/need 1
Member
|
@JonasFranzDEV 1.6 has been branched, so I'm going to move this to 1.7 milestone and set a backport label on this PR |
Member
|
@techknowlogick alright |
Member
Author
|
@techknowlogick backport pr is up: #5097 |
lafriks
approved these changes
Oct 17, 2018
bkcsoft
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #5096 +/- ##
=========================================
+ Coverage 37.4% 37.4% +<.01%
=========================================
Files 306 306
Lines 45374 45379 +5
=========================================
+ Hits 16973 16975 +2
- Misses 25947 25950 +3
Partials 2454 2454
Continue to review full report at Codecov.
|
techknowlogick
added
backport/done
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a hunk like this would fail:
@@ -1 +1,9 @@(note the missing
,after-1)This pr fixes this.