Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust maintainers #4979

Merged
merged 1 commit into from Sep 27, 2018
Merged

Adjust maintainers #4979

merged 1 commit into from Sep 27, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 26, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@79b4d47). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #4979   +/-   ##
========================================
  Coverage          ?   37.4%           
========================================
  Files             ?     306           
  Lines             ?   45343           
  Branches          ?       0           
========================================
  Hits              ?   16959           
  Misses            ?   25931           
  Partials          ?    2453

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b4d47...3034618. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 26, 2018
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Sep 26, 2018
lafriks
lafriks approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work and contribution to Gitea!

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 26, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 27, 2018
@lunny lunny merged commit b3393b5 into go-gitea:master Sep 27, 2018
@sapk sapk mentioned this pull request Jan 2, 2019
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-io @lunny @lafriks @bkcsoft