Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command for migrating database #4954

Merged
merged 5 commits into from
Oct 31, 2018
Merged

Add command for migrating database #4954

merged 5 commits into from
Oct 31, 2018

Conversation

rstefan1
Copy link
Contributor

Fixes #4948

@lunny lunny added this to the 1.7.0 milestone Sep 18, 2018
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Sep 18, 2018
adelowo
adelowo reviewed Sep 18, 2018
View reviewed changes
cmd/migrate.go Outdated
@@ -0,0 +1,51 @@
// Copyright 2014 The Gogs Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 2018 The Gitea Authors I think since it is a new file

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 18, 2018
jonasfranz
jonasfranz previously requested changes Sep 18, 2018
View reviewed changes
Gopkg.lock Outdated
]
solver-name = "gps-cdcl"
solver-version = 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these changed lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasFranzDEV solved

lafriks
lafriks requested changes Sep 18, 2018
View reviewed changes
cmd/migrate.go Show resolved Hide resolved
@rstefan1 rstefan1 force-pushed the migrate-cmd branch 2 times, most recently from bb979ae to 4f82093 Compare September 19, 2018 11:06
@codecov-io
Copy link

codecov-io commented Sep 19, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6eff62a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4954   +/-   ##
=========================================
  Coverage          ?   37.48%           
=========================================
  Files             ?      310           
  Lines             ?    45923           
  Branches          ?        0           
=========================================
  Hits              ?    17213           
  Misses            ?    26236           
  Partials          ?     2474

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eff62a...fe3fb39. Read the comment docs.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 19, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 6, 2018
@lunny
Copy link
Member

lunny commented Oct 18, 2018

@JonasFranzDEV need your approval.

@techknowlogick
Copy link
Member

@JonasFranzDEV need you approval

@lafriks lafriks dismissed jonasfranz’s stale review October 30, 2018 21:21

Dismissing review as requested changes are fixed

@techknowlogick techknowlogick merged commit 7edb930 into go-gitea:master Oct 31, 2018
@lunny lunny mentioned this pull request Nov 9, 2018
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo left review comments

@axifive axifive axifive approved these changes

@lafriks lafriks lafriks approved these changes

@appleboy appleboy appleboy approved these changes

@jonasfranz jonasfranz jonasfranz left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

CLI command for migrating database
10 participants
@rstefan1 @codecov-io @lunny @techknowlogick @appleboy @lafriks @axifive @jonasfranz @adelowo @bkcsoft