Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove traces of embedded TiDB #4906

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Remove traces of embedded TiDB #4906

merged 3 commits into from
Sep 11, 2018

Conversation

techknowlogick
Copy link
Member

Fixes #3357

@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 11, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 11, 2018
@lafriks
Copy link
Member

lafriks commented Sep 11, 2018

Unused import

@codecov-io
Copy link

Codecov Report

Merging #4906 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4906      +/-   ##
=========================================
+ Coverage   37.39%   37.4%   +<.01%     
=========================================
  Files         305     305              
  Lines       45223   45211      -12     
=========================================
  Hits        16911   16911              
+ Misses      25871   25859      -12     
  Partials     2441    2441
Impacted Files Coverage Δ
routers/install.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee9922...9e050b1. Read the comment docs.

@lunny
Copy link
Member

lunny commented Sep 11, 2018

I think the title should be embeded tidb. Distrituted Tidb could be used via mysql protocal.

@techknowlogick techknowlogick changed the title Remove traces of TiDB Remove traces of embedded TiDB Sep 11, 2018
@techknowlogick
Copy link
Member Author

@lunny ok, I changed the title

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 11, 2018
@techknowlogick techknowlogick merged commit f1ad4bb into go-gitea:master Sep 11, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-9 branch September 11, 2018 14:42
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial configuration screen - outdated info about databases
5 participants
@techknowlogick @lafriks @codecov-io @lunny @bkcsoft