-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chardet bug #4880
Fix chardet bug #4880
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4880 +/- ##
==========================================
+ Coverage 37.22% 37.22% +<.01%
==========================================
Files 305 305
Lines 45043 45053 +10
==========================================
+ Hits 16766 16771 +5
- Misses 25841 25844 +3
- Partials 2436 2438 +2
Continue to review full report at Codecov.
|
@lunny Why is this issue blocked, should it be moved to 1.7.0? |
This is blocked because I found the detection is not always successful. This will be replaced by #4950 |
Oh, I did not see that there is already PR about that issue |
@lafriks I forgot it also until @JonasFranzDEV 's comment. 🤣 |
Fixed by #4950 |
But for less text, the chardet maybe give wrong result.