Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Sep 6, 2018

But for less text, the chardet maybe give wrong result.

@lunny lunny added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Sep 6, 2018
@codecov-io
Copy link

Codecov Report

Merging #4880 into master will increase coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4880      +/-   ##
==========================================
+ Coverage   37.22%   37.22%   +<.01%     
==========================================
  Files         305      305              
  Lines       45043    45053      +10     
==========================================
+ Hits        16766    16771       +5     
- Misses      25841    25844       +3     
- Partials     2436     2438       +2
Impacted Files Coverage Δ
routers/repo/view.go 27.19% <25%> (+0.71%) ⬆️
models/repo_indexer.go 50.84% <0%> (-1.28%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1bf2a...aa46ac3. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 6, 2018
@techknowlogick techknowlogick changed the title ix chardet bug Fix chardet bug Sep 6, 2018
@jonasfranz
Copy link
Member

jonasfranz commented Sep 18, 2018

@lunny Why is this issue blocked, should it be moved to 1.7.0?

@lunny
Copy link
Member Author

lunny commented Sep 18, 2018

This is blocked because I found the detection is not always successful. This will be replaced by #4950

@lafriks
Copy link
Member

lafriks commented Sep 18, 2018

Oh, I did not see that there is already PR about that issue

@lunny
Copy link
Member Author

lunny commented Sep 19, 2018

@lafriks I forgot it also until @JonasFranzDEV 's comment. 🤣

@jonasfranz
Copy link
Member

Fixed by #4950

@jonasfranz jonasfranz closed this Sep 23, 2018
@lunny lunny deleted the lunny/fix_encoding branch September 23, 2018 09:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants