Punctuation changes in documentation #4866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4866 +/- ##
==========================================
- Coverage 37.22% 37.21% -0.01%
==========================================
Files 305 305
Lines 45043 45043
==========================================
- Hits 16767 16764 -3
- Misses 25841 25842 +1
- Partials 2435 2437 +2
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
adelowo
approved these changes
Sep 4, 2018
bkcsoft
added
lgtm/need 1
|
It'd be nice if you could update the PR title though |
davidak
suggested changes
Sep 4, 2018
| @@ -218,7 +218,7 @@ Values containing `#` or `;` must be quoted using `` ` `` or `"""`. | |||
| - Note that enabling sendmail will ignore all other `mailer` settings except `ENABLED`, | |||
| `FROM` and `SENDMAIL_PATH`. | |||
| - `SENDMAIL_PATH`: **sendmail**: The location of sendmail on the operating system. (can be | |||
There was a problem hiding this comment.
maybe remove the . after operating system?
techknowlogick
approved these changes
Sep 5, 2018
bkcsoft
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bunch of periods and a fixed link.