Add missing History link to directory listings #4754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature to list commits from a subdirectory is already there but so far the history link to it was missing. There is a History button in the view_file.tmpl already so avoid showing two history buttons in that case. The GitHub webinterface has the same History button in the same place so this makes gitea a little bit more compatible. Signed-off-by: Bernhard Froehlich <decke@bluelife.at>
Codecov Report
@@ Coverage Diff @@
## master #4754 +/- ##
=======================================
Coverage 20.69% 20.69%
=======================================
Files 167 167
Lines 32389 32389
=======================================
Hits 6702 6702
Misses 24706 24706
Partials 981 981Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lafriks
approved these changes
Aug 21, 2018
bkcsoft
added
lgtm/need 1
daviian
reviewed
Aug 22, 2018
appleboy
approved these changes
Aug 22, 2018
bkcsoft
added
lgtm/done
|
I will try to move the history button to the file actions and update the pull request. |
|
@decke any update? |
|
I'm currently on a business trip and will provide an update when I am back. Sorry for the delay. |
The feature to list commits from a subdirectory is already there but so far the history link to it was missing. There is a History button in the view_file.tmpl already so avoid showing two history buttons in that case. The GitHub webinterface has the same History button in the same place so this makes gitea a little bit more compatible. Signed-off-by: Bernhard Froehlich <decke@bluelife.at>
…itea into add-missing-history-link
|
That squashing didn't seem to work out properly. I will close this PR and create a new one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature to list commits from a subdirectory is already there but
so far the history link to it was missing. There is a History button
in the view_file.tmpl already so avoid showing two history buttons in
that case.
The GitHub webinterface has the same History button in the same place
so this makes gitea a little bit more compatible.
Signed-off-by: Bernhard Froehlich decke@bluelife.at