-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More detailed documentation on how to set up from binary #4121
More detailed documentation on how to set up from binary #4121
Conversation
Also change recommended file locations
**NOTE:** `/etc/gitea` is temporary set with write rights for user `git` so that Web installer could write configuration file. After installation is done it is recommended to set rights to read-only using: | ||
``` | ||
chmod 750 /etc/gitea | ||
chmod 644 /etc/gitea/app.ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't give read access to all, since app.ini holds some sensitive data!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chmod 750 /etc/gitea
does allow only root:git access to contents inside this directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed that totally!
Codecov Report
@@ Coverage Diff @@
## master #4121 +/- ##
=======================================
Coverage 19.97% 19.97%
=======================================
Files 153 153
Lines 30494 30494
=======================================
Hits 6091 6091
Misses 23489 23489
Partials 914 914 Continue to review full report at Codecov.
|
USER=git | ||
USERBIND="setcap cap_net_bind_service=+ep" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove that ?
I suppose that it is because it is not needed for basic config listening on upper ports but maybe this need a comment to activate this line if gitea need to listen under 1024 port like ssh (port 22).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sapk added comment
Also change recommended file locations to have more common Linux layout