Skip to content

Conversation

@InonS
Copy link
Contributor

@InonS InonS commented Jun 4, 2018

#4035 (comment)

@ohwgiles points out that the config section should, in fact, still be in accordance with the "server" struct, which contains the "LFS" struct. I should just remove the line

sec = Cfg.Section("LFS")

go-gitea#4035 (comment)

@ohwgiles points out that the config section should, in fact, still be in accordance with the "server" struct, which contains the "LFS" struct. I should just remove the line
```
sec = Cfg.Section("LFS")
```
@codecov-io
Copy link

Codecov Report

Merging #4113 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4113   +/-   ##
=======================================
  Coverage   19.97%   19.97%           
=======================================
  Files         153      153           
  Lines       30494    30494           
=======================================
  Hits         6091     6091           
  Misses      23489    23489           
  Partials      914      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62bc33...21481d7. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 4, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 4, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2018
@lafriks lafriks merged commit 1bcabb8 into go-gitea:master Jun 4, 2018
@lunny lunny added the type/bug label Jun 5, 2018
@lunny lunny added this to the 1.5.0 milestone Jun 5, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants